493976 - [@font-face] Timeout caused by src-format-arabic.html

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, defect)

Description

[Jeff Muizelaar [:jrmuizel]]

No idea what could be causing this so lets just start with this:

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox3.5/1242826454.1242832219.16317.gz

Comment 1

[(no longer active)]

Happened on Windows, too.

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1243737952.1243742820.1578.gz
WINNT 5.2 mozilla-central unit test on 2009/05/30 19:45:52

Comment 2

[Serge Gautherie (:sgautherie)]

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey-Ports/1243857967.1243864878.29657.gz
WINNT 5.2 comm-1.9.1 unit test on 2009/06/01 05:06:07

Comment 3

[Jesse Ruderman]

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1245499305.1245505836.20532.gz
WINNT 5.2 mozilla-central unit test on 2009/06/20 05:01:45

Comment 4

[Serge Gautherie (:sgautherie)]

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1245749499.1245756014.13659.gz
WINNT 5.2 mozilla-central unit test on 2009/06/23 02:31:39

Please, fix or disable the test which aborts the test suite!

Comment 5

[John Daggett (:jtd)]

No idea what's causing this, should be a simple lookup failure resulting in fallback behavior.  The @font-face rule involve only uses src: local() so there's no load interaction.

Disabling for now:

http://hg.mozilla.org/mozilla-central/rev/010e8c342653
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/f6604b637efc

Comment 6

[Daniel Holbert [:dholbert]]

Very weird -- we hit this again, even though the "helveticaneue-ultra.html" test is apparently skipped:
{ 
REFTEST TEST-KNOWN-FAIL | http://localhost:4444/1245950829498/38/font-face/src-list-local-localized.html | (SKIP)
REFTEST TEST-KNOWN-FAIL(EXPECTED RANDOM) | file:///e:/builds/moz2_slave/mozilla-central-win32-unittest/build/layout/reftests/font-face/src-list-local-ps.html |
REFTEST TEST-KNOWN-FAIL | file:///e:/builds/moz2_slave/mozilla-central-win32-unittest/build/layout/reftests/font-face/helveticaneue-ultra.html | (SKIP)

command timed out: 300 seconds without output
}

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1245944174.1245953308.16268.gz
WINNT 5.2 mozilla-central unit test on 2009/06/25 08:36:14

Comment 7

[Jesse Ruderman]

It's probably the test after helveticaneue-ultra that's timing out.

Comment 8

[Daniel Holbert [:dholbert]]

Ah -- that'd be src-format-arabic.html

Quoting layout/reftests/font-face/reftest.list :
> 39 skip-if(MOZ_WIDGET_TOOLKIT!="cocoa") == helveticaneue-ultra.html helveticaneue-ultra-ref.html # 493976
> 40 
> 41 # Arabic support requires AAT fonts under Mac OS, OpenType otherwise
> 42 random-if(MOZ_WIDGET_TOOLKIT!="cocoa") HTTP(..) == src-format-arabic.html src-format-arabic-aat-ref.html

Test & reference URLs:
http://mxr.mozilla.org/mozilla-central/source/layout/reftests/font-face/src-format-arabic.html
http://mxr.mozilla.org/mozilla-central/source/layout/reftests/font-face/src-format-arabic-aat-ref.html

Comment 9

[Curtis Bartley [:cbartley]]

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox3.5/1247478195.1247488246.8141.gz&fulltext=1

Comment 10

[Daniel Holbert [:dholbert]]

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1248382066.1248391538.3593.gz
WINNT 5.2 mozilla-central unit test on 2009/07/23 13:47:46

Comment 11

[Serge Gautherie (:sgautherie)]

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox3.5-Unittest/1248330396.1248333004.15691.gz
WINNT 5.2 mozilla-1.9.1 test everythingelse on 2009/07/22 23:26:36

Please, re-enable helveticaneue-ultra.html and disable the next test.

Comment 12

[Jesse Ruderman]

http://hg.mozilla.org/mozilla-central/rev/c023fd5706ff

"Move around Arabic reftest to see if it's the cause of reftest timeout problems."

Comment 13

[John Daggett (:jtd)]

WINNT 5.2 mozilla-central unit test on 2009/07/27 08:52:43
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1248709963.1248719585.24874.gz

Timeout occurred just before Arabic tests.  Commenting the tests out for now on trunk.
http://hg.mozilla.org/mozilla-central/rev/45418f4ad64a

Comment 14

[Serge Gautherie (:sgautherie)]

(In reply to comment #13)
> WINNT 5.2 mozilla-central unit test on 2009/07/27 08:52:43

Except for comment 0 log, which is now too old to access,
all reports here are on Windows!

> Commenting the tests out for now on trunk.

Why commenting it out, instead of "skip(windows)" only?
1.9.1 needs the workaround too.

Comment 15

[Serge Gautherie (:sgautherie)]

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey2.0/1250773874.1250781012.16523.gz
WINNT 5.2 comm-1.9.1 unit test on 2009/08/20 06:11:14

Comment 16

[Serge Gautherie (:sgautherie)]

(In reply to comment #12)
> http://hg.mozilla.org/mozilla-central/rev/c023fd5706ff

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/1054f5a3cdaa

(In reply to comment #13)
> http://hg.mozilla.org/mozilla-central/rev/45418f4ad64a

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/871f45f364a5

Comment 17

[John Daggett (:jtd)]

Don't know why this became security-sensitive core...

Comment 18

[Daniel Holbert [:dholbert]]

dveditz, could you clear the "Security-Sensitive Core" checkmark here? That somehow got ticked when John wontfix'ed this, and neither he nor I seem to have privileges to clear it.

Comment 19

[John Daggett (:jtd)]

Attachment: patch, remove old, unused reftest

Remove old reftest originally designed for testing AAT fonts.

Comment 20

[Daniel Holbert [:dholbert]]

Comment on attachment 8710851 [details] [diff] [review]
patch, remove old, unused reftest

Review of attachment 8710851 [details] [diff] [review]:
-----------------------------------------------------------------

Two nits:
 (1) s/i/o/ in "r=dhilbert" :)

 (2) The commit message (currently "remove old reftest") could use a bit more explanation/clarification. Please mention the feature that was being tested, & that it no longer exists or is obsolete or whatever.

Comment 21

[John Daggett (:jtd)]

(In reply to Daniel Holbert [:dholbert] from comment #20)

>  (1) s/i/o/ in "r=dhilbert" :)

argh, a thousand pardons!

Comment 22

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/cfeefd4e5ea2