493978 - Disable tab-detach when the tab is dropped very close to the tabbar

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Asaf Romano (gone)]

Disable tab-detach when the tab is dropped very close to the tabbar.

Detach is already disabled in the browser-toolbox, it should also be disabled in the first few pixels of the content area.

<beltzner>	Mano: as for a catch-mistakes area; I think I said before I'm happy to have a space that's a half-tabstrip high at the top of the content area which is a no-op for dragging tabs

Comment 1

[Asaf Romano (gone)]

Attachment: patch

Also fixes bug 494026.

Comment 2

[Dietrich Ayala (:dietrich)]

Comment on attachment 378741 [details] [diff] [review]
patch

r=me

Comment 3

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 378741 [details] [diff] [review]
patch

a191=beltzner once we get a set of green unit test cycles on mozilla-central

Comment 4

[Asaf Romano (gone)]

landed on mozilla-central:
http://hg.mozilla.org/mozilla-central/rev/4f1a03b74196

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

Can we get this landed on 1.9.1 ASAP? We're gonna respin the nightlies there and I think it could really (really) benefit from additional testing.

Comment 6

[:Gavin Sharp [email: [e-mail]]]

https://hg.mozilla.org/releases/mozilla-1.9.1/rev/bd95115df4f2

Comment 7

[Aakash Desai [:aakashd]]

verified FIXED on builds:

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090522 Minefield/3.6a1pre ID:20090522032716

and

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1pre) Gecko/20090522 Shiretoko/3.5pre ID:20090522030802

Comment 8

[toughstrong]

This is a crazy function, tear off a tab to a new window? 
why? 
why i need such a function? 
why i need to tear off a tab to a new window in a tabbed program? 
Salute to the guy implementing the function.