loading ogg file causes browser to grow memory footprint to several gig

VERIFIED FIXED in mozilla1.9.2a1

Status

()

Core
Audio/Video
VERIFIED FIXED
9 years ago
9 years ago

People

(Reporter: blizzard, Assigned: cajbir)

Tracking

({verified1.9.1})

Trunk
mozilla1.9.2a1
All
Mac OS X
verified1.9.1
Points:
---
Bug Flags:
wanted1.9.1 +
in-testsuite ?

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

9 years ago
Tried on the 1.9.1 branch as well as trunk.  Loading the above file and playing it in Firefox will cause it to grow to a couple of gig on my mac and it never plays the file.

It was apparently generated using ffmpeg 0.5.
Yeah, it was generated by ffmpeg 0.5

Steps:

1- http://blip.tv/file/2137910 Downloaded divx version
2- Converted with ffmpeg 0.5 macports edition with just: ffmpeg -i input file output.ogg

I have generated the file with ffmpeg2theora on Mac and it plays nice.
(Reporter)

Comment 2

9 years ago
Greg Maxell says it plays fine in oggplayer and player_example.  It plays fine in VLC on the mac as well.
(Reporter)

Comment 3

9 years ago
Greg just found that the file is encoded with flac as the audio stream.  We should handle that gracefully because ffmpeg is going to generate this crap from time to time.
Flags: blocking1.9.1?
I don't think we should block on this at this stage, but it sounds like a fix would be pretty easy, maybe we can get it in.
Assignee: nobody → chris.double
Flags: blocking1.9.1? → wanted1.9.1+
(Assignee)

Comment 5

9 years ago
Created attachment 379042 [details] [diff] [review]
Fix

The flac track was being marked as active even though we don't support flac. This triggers a liboggplay bug where active tracks that don't have backend support (we disable it in build flags in supporting libraries) cause this memory growth issue.

Fixed by only activating the tracks we are actually know we want to play.

Also fixed a bug where after seek we activated all tracks in the file rather than the audio and video track we are playing.
Attachment #379042 - Flags: superreview?(roc)
Attachment #379042 - Flags: review?(roc)
Attachment #379042 - Flags: superreview?(roc)
Attachment #379042 - Flags: superreview+
Attachment #379042 - Flags: review?(roc)
Attachment #379042 - Flags: review+
Whiteboard: [needs landing][needs 191 approval]
Comment on attachment 379042 [details] [diff] [review]
Fix

Low risk. Stops us from blowing up when we encounter videos containing tracks we can't handle (which do exist).
Attachment #379042 - Flags: approval1.9.1?
Comment on attachment 379042 [details] [diff] [review]
Fix

a191=beltzner
Attachment #379042 - Flags: approval1.9.1? → approval1.9.1+
http://hg.mozilla.org/mozilla-central/rev/1b43b06c2052
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Flags: in-testsuite?
Resolution: --- → FIXED
Whiteboard: [needs landing][needs 191 approval] → [needs 191 approval]
Verified fixed on trunk and 1.9.1 with builds on Windows and OS X like:

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090527 Minefield/3.6a1pre ID:20090527031500

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1pre) Gecko/20090527 Shiretoko/3.5pre ID:20090527031214
Status: RESOLVED → VERIFIED
Keywords: fixed1.9.1 → verified1.9.1
Hardware: x86 → All
Target Milestone: --- → mozilla1.9.2a1
You need to log in before you can comment on or make changes to this bug.