Make us not fall off trace when accessing "window".

RESOLVED FIXED

Status

()

Core
DOM
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: jst, Assigned: jst)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

9 years ago
Created attachment 378705 [details] [diff] [review]
Fix.

Spin-off from bug 492649. Right now we'll fall off trace if script accesses the global property window, which is of course pretty common. Fixing it is trivial, see attached patch.
Attachment #378705 - Flags: superreview?(mrbkap)
Attachment #378705 - Flags: review?(mrbkap)

Updated

9 years ago
Attachment #378705 - Flags: superreview?(mrbkap)
Attachment #378705 - Flags: superreview+
Attachment #378705 - Flags: review?(mrbkap)
Attachment #378705 - Flags: review+
(Assignee)

Comment 1

9 years ago
Fixed on trunk and branch.

http://hg.mozilla.org/mozilla-central/rev/39ecde227c8d
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/b380d9251b9b
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Keywords: fixed1.9.1
Resolution: --- → FIXED
(Assignee)

Comment 2

9 years ago
Backed out of 1.9.1 to see if this caused bug 494255.

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/ca05a66098b7
Keywords: fixed1.9.1

Updated

9 years ago
Assignee: nobody → jst
Backing out doesn't seem to have changed txul.
(Assignee)

Comment 4

9 years ago
Yes. But given the fact that this buys us very little, if anything, I'm not going to check this back into 1.9.1. Once we're able to stay on trace through a XOW, we'll benefit from this, but until then, not really.
Comment on attachment 378705 [details] [diff] [review]
Fix.

Unmarking approval per jst.
Attachment #378705 - Flags: approval1.9.1+
You need to log in before you can comment on or make changes to this bug.