Closed Bug 49411 Opened 24 years ago Closed 24 years ago

cache charset detector in libmime

Categories

(MailNews Core :: Internationalization, defect, P2)

Product:
MailNews Core
Component:
Internationalization
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: nhottanscp, Assigned: nhottanscp)

Details

(Keywords: perf, Whiteboard: [nsbeta3+])

Charset detector is created in MimeCharsetConverterClass::Init(), and the class is not cached, so it's created per line. We can cache a detector inside a class since there is only one detecter selection by the pref (i.e. not per message).
Status: NEW → ASSIGNED
Keywords: nsbeta3, perf
Marking nsbeta3+ per I18N bug triage.
Priority: P3 → P2
Whiteboard: [nsbeta3+]
I made a change to store a detector as static. But detectors do not work correctly unless creating them every time. They may be holding states internally. I need to talk to Frank about this.
Checked in a fix for the detector to reset internal states for string based detection.
what is the remaining part of the bug ?
I have a patch to cache a detector. I will check in after it's reviewed.
Checked in the fix.
Status: ASSIGNED → NEW
fixed
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Looks like this would be best verified by naoki. Thanks!
QA Contact: momoi → nhotta
verified
Status: RESOLVED → VERIFIED
Product: MailNews → Core
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.