494126 - Text is vertically offset in input on http://cupertino.org/

Status: RESOLVED WORKSFORME

(Core :: Layout: Form Controls, defect)

Description

[Tony Chung [:tchung]]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090520 Minefield/3.6a1pre
Build Identifier: 

The text in the searchbox on the URL is offset in the div.  This only happens on trunk, and not on 191 branch.

See screenshot: http://www.grabup.com/uploads/ff028fbb1029bff770140f25e92fb082.png

The source file is attached.   Search for "searchbox"

Reproducible: Always

Steps to Reproduce:
1. Install 5/20/2009 trunk build.  go to URL
2. Click on the upper right corner searchbox
3. type in something.   Verify the text is offset in the searchbox div

* This looks normal on 1.9.1branch
Actual Results:  
Text is offset in searchbox, and bleeds out of the border.  See screenshot: http://www.grabup.com/uploads/ff028fbb1029bff770140f25e92fb082.png

Expected Results:  
Text should be contained within searchbox

Comment 1

[Tony Chung [:tchung]]

Attachment: Search Text box source

Comment 2

[Markus Stange [:mstange]]

I'm guessing that this was caused by bug 481751. Can somebody confirm?

Comment 3

[philippe (part-time)]

(In reply to comment #2)
> I'm guessing that this was caused by bug 481751. Can somebody confirm?

yes: given the regression range I get:

OK
http://hg.mozilla.org/mozilla-central/rev/9703fd69e126
Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090518 Minefield/3.6a1pre

fails
http://hg.mozilla.org/mozilla-central/rev/409416c625bc
Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090519 Minefield/3.6a1pre

http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=9703fd69e126&tochange=409416c625bc

Comment 4

[Karl Tomlinson (:karlt)]

Attachment: reduced html,css

(This references an image from http://cupertino.org/.)

The input element is 27px high including 4px top-padding
(surrounded by red dashed outline).
The background image (including border) is 20px high.

Comment 5

[Karl Tomlinson (:karlt)]

Previous behavior was to align the top of the text with the top of the content rect (i.e. bottom of the top-padding) of the input element.

Behavior after bug 481751 is to vertically center the text in the content area of the input.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Need to evaluate whether it's ok to ship like this.  :(

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Seems like a pretty strange use of input boxes to me; if they're going to use a background like that, shouldn't they at least make the input's size match it?

Comment 9

[(mostly gone) XtC4UaLL [:xtc4uall]]

per Bug 525897 sites like Youtube and Apple are affected too.

Comment 10

[Michelle Funches - QA]

Cannot reproduce
Version 	47.0.1
Build ID 	20160623154057
User Agent 	Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:47.0) Gecko/20100101 Firefox/47.0