494224 - Star is not displayed in location bar list items when clicking dropdown arrow

Status: RESOLVED INACTIVE

(Firefox :: Address Bar, defect)

Description

[Chris Ilias [:cilias]]

Build identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1pre) Gecko/20090521 Shiretoko/3.5pre

My guess is that this is a regression from bug 485122.

I have the location bar set to display both bookmarks and history. If I click on the dropdown arrow on the location bar (not typing, just viewing the top items), there is no star displayed beside entries which are bookmarks.

I've only tested on Shiretoko/Mac.

Comment 1

[Mike Beltzner [:beltzner, not reading bugmail]]

Don't think this blocks, though I'm pretty sure it's unintentional.

Comment 2

[Spencer Selander [greenknight]]

It's the same in WinXP.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090521 Minefield/3.6a1pre ID:20090521043940

Comment 3

[Samuel Sidler (old account; do not CC)]

We should fix this in 1.9.2.

Comment 4

[(mostly gone) XtC4UaLL [:xtc4uall]]

ranges this regressed:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=ed38105c9c2a&tochange=da613c9fae8c
http://hg.mozilla.org/releases/mozilla-1.9.1/pushloghtml?fromchange=e49c05fc9122&tochange=acd2d4638228
=> probably by check-in of Bug 485122.

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

I agree that we should fix it; in the future, you should feel free to assign regressions to their regressors, as I've just done.

Mardak: can you restore this functionality, please?

Comment 6

[Ed Lee :Mardak]

Attachment: v1

No tests yet.. still compiling.. but I tried it out on a nightly build by modifying components/nsPlacesAutoComplete.js

Comment 7

[(mostly gone) XtC4UaLL [:xtc4uall]]

Edward, is that patch reviewable yet (presuming you forgot about it ;-)?

Comment 8

[Dennis Schieferdecker]

I can confirm that the patch by Edward solves the problem. But I recommend using a new function _hasDefaultBehaviour to retrieve the default autocomplete behaviour instead of adding a parameter to _hasBehaviour for code clarity.

Comment 9

[Marco Bonardo [:mak]]

Comment on attachment 399341 [details] [diff] [review]
v1

the proposed change is correct (f+), but I second the request in comment 8 for a new hasDefaultBehavior method, plus this should have a test (r-).

Comment 10

[Chris Ilias [:cilias]]

-->Trunk
Still see this in Fx4 nightlies.

Comment 11

[Dennis Schieferdecker]

The bug is still present in the official Firefox 4.0 release despite a working fix being available for almost one year now. The proposed fix still works with Firefox 4.0 by applying the diff to the new version of nsPlacesAutoComplete.js.

To emphasize, the described bug occurs *only* when using the pulldown menu. It explicitly does not occur when typing and getting suggestions.

Comment 12

[Dennis Schieferdecker]

Bug 494224 remains present in Firefox 5.0 Beta 1. The proposed fix can still be used to rectify the problem.

Comment 13

[Dennis Schieferdecker]

After further investigation, the cause of this bug lies in the restriction of "empty searches" (i.e. searches for ""). By default, search results of empty searches are restricted to previously typed and visited urls. Using the pulldown menu button of the url bar also counts as "empty search".

With this new information, the correct solution would be to differentiate between an "empty search" and using the pulldown menu button, and only applying the restrictions to the former. As to how, I currently do not know.

Meanwhile, an easy userland bypass is to set default.behavior.emptyRestriction = 0 (no restrictions) or = 32 (url must have been typed previously). But this also affects true "empty searches".

Still, a general design question remains:
If the shown results are restricted to the history, should the star symbol indicating bookmarked urls be explictly hidden (current design) or not?

Comment 14

[BMO Automation]

Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.