494257 - Tryserver talos (mac and win32) broken with cvs builds

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Jeff Muizelaar [:jrmuizel]]

When using sendchange.cgi with the CVS trunk option. I get the following results
for the talos runs:
http://tinderbox.mozilla.org/showlog.cgi?log=MozillaTry/1242921540.1242929266.8709.gz
http://tinderbox.mozilla.org/showlog.cgi?log=MozillaTry/1242921540.1242925153.32446.gz

etc.

The mac run errors out with:
IOError: [Errno 2] No such file or directory: '../Minefield.app/Contents/MacOS/chrome'

I also don't seem to get mails with these results, but I suppose that's a different bug.

Comment 1

[[e-mail] (:bhearsum)]

This is almost certainly a regression after bug 410510. I'll see what's going on.

As for the mails, I wasn't planning to enable them for CVS builds since we see so few of them (and it would require extra work).

Comment 2

[[e-mail] (:bhearsum)]

AFAICT linux still works, updating the summary to match.
http://tinderbox.mozilla.org/showlog.cgi?log=MozillaTry/1242921540.1242954368.28589.gz&fulltext=1

Comment 3

[[e-mail] (:bhearsum)]

Attachment: fix try talos on mac and win32

For the Mac issue, I took your advice and simply switched to the FindFile method for this factory. I tested all platforms and they're working well with it (yay). This must've been an issue ever since we changed the branding on CVS trunk back in September.

The win32 issue was definitely a regression from my recent cleanup. Specifically, MozillaUploadTryBuild now sets 'uploadpath' as a build property. Since we upload the exe after the zip file the sendchange step ended up passing along the exe to talos. I've simply switched things around so that the zip is uploaded last.

Comment 4

[[e-mail] (:bhearsum)]

Comment on attachment 379083 [details] [diff] [review]
fix try talos on mac and win32

changeset:   1158:3124ed170be0

Comment 5

[[e-mail] (:bhearsum)]

I did a test submission of a CVS patch and everything (build&talos) worked fine.