Closed
Bug 494490
Opened 16 years ago
Closed 4 years ago
make install on linux installs the system_wrappers{_js} in includedir
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
INCOMPLETE
mozilla1.9.2a1
People
(Reporter: wuno, Assigned: wuno)
References
Details
Attachments
(2 files, 1 obsolete file)
|
3.41 KB,
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
|
2.22 KB,
patch
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2a1pre) Gecko/20090522 Minefield/3.6a1pre
Build Identifier:
after bug488175 the system_wrappers get installed in the includedir. Should they be added to removed-files or should be added --exclude=system_wrappers* to the respective tar command in toolkit/mozapps/install/packager.mk?
Reproducible: Always
|
||
Comment 1•16 years ago
|
||
I'd actually like to move system_wrappers out of dist/include into, say dist/system_wrappers
|
Assignee | |
Comment 2•16 years ago
|
||
|
|
Assignee | |
Comment 3•16 years ago
|
||
probably Wan-Teh has to r as well
Attachment #379289 -
Flags: review?(benjamin)
|
|
||
Updated•16 years ago
|
Attachment #379288 -
Flags: review?(benjamin) → review+
|
|
||
Comment 4•16 years ago
|
||
Comment on attachment 379288 [details] [diff] [review]
patch for M-C and js
[Checkin: Comment 8]
Are you sure the NSPR patch is necessary?
|
|
||
Updated•16 years ago
|
Assignee: wuno → nobody
Product: Toolkit → Core
|
|
||
Updated•16 years ago
|
Attachment #379289 -
Flags: review?(benjamin) → review?(wtc)
|
|
Assignee | |
Updated•16 years ago
|
Attachment #379289 -
Flags: review?(wtc)
|
|
Assignee | |
Comment 5•16 years ago
|
||
Comment on attachment 379289 [details] [diff] [review]
patch for nspr
(In reply to comment #4)
> (From update of attachment 379288 [details] [diff] [review])
> Are you sure the NSPR patch is necessary?
Tried w/o the NSPR patch w/ and w/o --system-nspr
works w/o the nspr patch
|
|
Assignee | |
Updated•16 years ago
|
Keywords: checkin-needed
Version: unspecified → Trunk
|
||
Updated•16 years ago
|
Attachment #379289 -
Flags: review+
|
|
||
Comment 6•16 years ago
|
||
Comment on attachment 379289 [details] [diff] [review]
patch for nspr
r=wtc. Since NSPR isn't using the system header wrappers,
this patch is modifying dead code. Alternatively, we can
just delete the dead code.
|
|
Assignee | |
Comment 7•16 years ago
|
||
(In reply to comment #6)
> Alternatively, we can
> just delete the dead code.
Well, then do it, couldn't then nsprpub/config/make-system-wrappers.pl cvs removed?
Attachment #380517 -
Flags: review?(wtc)
|
|
Assignee | |
Updated•16 years ago
|
Attachment #379289 -
Attachment is obsolete: true
|
||
Updated•16 years ago
|
Assignee: nobody → wuno
|
||
Comment 8•16 years ago
|
||
Comment on attachment 379288 [details] [diff] [review]
patch for M-C and js
[Checkin: Comment 8]
http://hg.mozilla.org/mozilla-central/rev/5f14dd5ec14a
Attachment #379288 -
Attachment description: patch for M-C and js → patch for M-C and js
[Checkin: Comment 8]
|
|
||
Updated•16 years ago
|
|
|
Assignee | |
Comment 9•16 years ago
|
||
Wan-Teh,
do you have any preferences modification (https://bugzilla.mozilla.org/attachment.cgi?id=379289) vs. removal (https://bugzilla.mozilla.org/attachment.cgi?id=380517) of the dead code?
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
| Comment hidden (Intermittent Failures Robot) |
|
|
||
Comment 11•4 years ago
|
||
This is 12 years old, and I'm not sure if the context still applies. Closing :)
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → INCOMPLETE
You need to log in
before you can comment on or make changes to this bug.
Description
•