make install on linux installs the system_wrappers{_js} in includedir

ASSIGNED
Assigned to

Status

Firefox Build System
General
ASSIGNED
9 years ago
2 months ago

People

(Reporter: Walter Meinl, Assigned: Walter Meinl)

Tracking

Trunk
mozilla1.9.2a1
x86
Linux

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

9 years ago
User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2a1pre) Gecko/20090522 Minefield/3.6a1pre
Build Identifier: 

after bug488175 the system_wrappers get installed in the includedir. Should they be added to removed-files or should be added --exclude=system_wrappers* to the respective tar command in toolkit/mozapps/install/packager.mk?

Reproducible: Always

Comment 1

9 years ago
I'd actually like to move system_wrappers out of dist/include into, say dist/system_wrappers
(Assignee)

Comment 2

9 years ago
Created attachment 379288 [details] [diff] [review]
patch for M-C and js
[Checkin: Comment 8]
Assignee: nobody → wuno
Status: NEW → ASSIGNED
Attachment #379288 - Flags: review?(benjamin)
(Assignee)

Comment 3

9 years ago
Created attachment 379289 [details] [diff] [review]
patch for nspr

probably Wan-Teh has to r as well
Attachment #379289 - Flags: review?(benjamin)

Updated

9 years ago
Attachment #379288 - Flags: review?(benjamin) → review+

Comment 4

9 years ago
Comment on attachment 379288 [details] [diff] [review]
patch for M-C and js
[Checkin: Comment 8]

Are you sure the NSPR patch is necessary?

Updated

9 years ago
Assignee: wuno → nobody
Component: Build Config → Build Config
Product: Toolkit → Core

Updated

9 years ago
Attachment #379289 - Flags: review?(benjamin) → review?(wtc)
(Assignee)

Updated

9 years ago
Attachment #379289 - Flags: review?(wtc)
(Assignee)

Comment 5

9 years ago
Comment on attachment 379289 [details] [diff] [review]
patch for nspr

(In reply to comment #4)
> (From update of attachment 379288 [details] [diff] [review])
> Are you sure the NSPR patch is necessary?

Tried w/o the NSPR patch w/ and w/o --system-nspr
works w/o the nspr patch
(Assignee)

Updated

9 years ago
Keywords: checkin-needed
Version: unspecified → Trunk

Updated

9 years ago
Attachment #379289 - Flags: review+

Comment 6

9 years ago
Comment on attachment 379289 [details] [diff] [review]
patch for nspr

r=wtc.  Since NSPR isn't using the system header wrappers,
this patch is modifying dead code.  Alternatively, we can
just delete the dead code.
(Assignee)

Comment 7

9 years ago
Created attachment 380517 [details] [diff] [review]
delete dead code from nsprpub

(In reply to comment #6)
> Alternatively, we can
> just delete the dead code.
Well, then do it, couldn't then nsprpub/config/make-system-wrappers.pl cvs removed?
Attachment #380517 - Flags: review?(wtc)
(Assignee)

Updated

9 years ago
Attachment #379289 - Attachment is obsolete: true
Assignee: nobody → wuno
Comment on attachment 379288 [details] [diff] [review]
patch for M-C and js
[Checkin: Comment 8]


http://hg.mozilla.org/mozilla-central/rev/5f14dd5ec14a
Attachment #379288 - Attachment description: patch for M-C and js → patch for M-C and js [Checkin: Comment 8]
Flags: in-testsuite-
Keywords: checkin-needed
Target Milestone: --- → mozilla1.9.2a1
Depends on: 488175
(Assignee)

Comment 9

9 years ago
Wan-Teh,
do you have any preferences modification (https://bugzilla.mozilla.org/attachment.cgi?id=379289) vs. removal (https://bugzilla.mozilla.org/attachment.cgi?id=380517) of the dead code?

Updated

2 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.