494502 - Caller of nsDOMStorage::InitAsSessionStorage doesn't check return value

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

This is in nsDocShell::GetSessionStorageForPrincipal.  So it's possible for that code to hand out storage objects with an empty mDomain, for example.  Should only happen if aPrincipal is system, so not sure this should block, but I'm not sure what all the invariants in this code are, so nominating just in case.

Note that this makes the patch for bug 494453 not actually throw when accessing sessionStorage on a chrome page.

Comment 1

[Mike Beltzner [:beltzner, not reading bugmail]]

Blocking for now; if this is fixed by backing out bug 455070 then we don't need to block on this anymore.

Comment 2

[Johnny Stenback (:jst)]

Fixed for 1.9.1 by the fix for bug 495112.

Comment 3

[Mike Beltzner [:beltzner, not reading bugmail]]

I think we just want to mark this one FIXED as well and file a new bug for trunk if it remains unfixed there?

Comment 4

[Boris Zbarsky [:bzbarsky]]

I'd be fine with that; please file the new bug (and request blocking1.9.2) before resolving this one, though.

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

Actually, thinking things through more, I think what we want to do is land bug 495112 on trunk as well and then file an entirely new bug (no idea what we'd call that) and nominate it for blocking1.9.2 as bz suggests.

jst: can you make sure that happens? Also commented to this effect in bug 495112

Comment 6

[Johnny Stenback (:jst)]

Fixed on trunk by the fix for bug 495112. Bug 495337 filed as a followup.

http://hg.mozilla.org/mozilla-central/rev/363750f510ec