494504 - Stop downloading data when logical EOS is reached

Status: RESOLVED DUPLICATE of bug 455165

(Core :: Audio/Video, defect)

Description

[Rich Walsh]

At the end of a track from this streaming radio station, sa_stream_drain() is called but the stream is never closed.  Network activity continues, but no function in sydney_audio is ever called again.  The tab has to be closed to destroy the stream & halt the download.  The media start/stop button has no effect.

I get the same results with http://radio1190.colorado.edu:8000/high.ogg  However, this stream never plays for more than 10 seconds before it dies.

This issue was identified while developing the sydney_audio backend for OS/2 and appears to be present in the Windows & Mac versions of Firefox 3.5b4.  This may be a duplicate of Bug 455165 but I am unable to determine if these streams use chained ogg files.

Comment 1

[cajbir (:cajbir)]

I tested quickly today (I'm on a slow mobile data network connection) and it does appear that these are icecast streams using chained oggs.

We need to close the stream after liboggplay tells us it can't play any more of the stream.

Comment 2

[Rich Walsh]

(In reply to comment #1)
> We need to close the stream after liboggplay tells us it can't play any more
> of the stream.

My apologies:  my claim that the stream doesn't get closed was based on out-of-date code.  Using trunk code pulled Saturday, May 23rd, the stream is closed at the end of the track.  However, network activity continues unabated (an item of concern for someone "on a slow mobile data network connection", I would think).

Comment 3

[cajbir (:cajbir)]

By 'stream' you mean audio stream, right? I was meaning network stream so I think we're both right there :)

Comment 4

[Paul Adenot (:padenot)]

This will be solved by Bug 455165, which allows to play chained streams, and by Bug 559468, which allows one to stop the download of a media stream.

Comment 5

[Paul Adenot (:padenot)]

Bug 455165 is fixed, so this is fixed as well.