494582 - release repacks hang on 'echo None'

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Nick Thomas [:nthomas] (UTC+12)]

This is like bug 494367, only for releases. Eg
http://staging-master.build.mozilla.org:8010/builders/linux_repack/builds/1510

By the looks we'll have to bung in some tree value when setting up the DependentL10n scheduler and ReleaseRepackFactory. That right coop/Axel ?

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

Blocks 3.5rc1 builds starting.

Comment 2

[Chris AtLee [:catlee]]

Attachment: Force self.tree to be a string when echoing

Would something like this work?

Comment 3

[Nick Thomas [:nthomas] (UTC+12)]

It works in the sense of not stalling slaves, from the first chunk of the patch. But it mangles the printing of all the properties except tree. Eg
 http://staging-master.build.mozilla.org:8010/builders/linux_repack/builds/1522
has 
 echo TinderboxPrint: buildnumber: <buildbot.process.properties.WithProperties instance at 0xa67230c>

Comment 4

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: Provided a tree definition for releases

This works fine in staging, and is similar to what we do in dev builds. I'm not sure if setting it on the scheduler is strictly necessary though.

Comment 5

[Axel Hecht [:Pike]]

Comment on attachment 379426 [details] [diff] [review]
Provided a tree definition for releases

Looks good to me.

Comment 6

[Axel Hecht [:Pike]]

PS: The right place to set the default would have been in DependentL10n, setting it to "notset" or something instead of None.

Comment 7

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 379426 [details] [diff] [review]
Provided a tree definition for releases

catlee said this looked fine on IRC.

committed changeset 1167:531256cb3b6a

production-master reconfig'd