Closed Bug 494582 Opened 13 years ago Closed 13 years ago

release repacks hang on 'echo None'

Categories

(Release Engineering :: General, defect)

x86
All
defect
Not set
blocker

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: nthomas, Assigned: nthomas)

References

Details

Attachments

(1 file, 1 obsolete file)

This is like bug 494367, only for releases. Eg
http://staging-master.build.mozilla.org:8010/builders/linux_repack/builds/1510

By the looks we'll have to bung in some tree value when setting up the DependentL10n scheduler and ReleaseRepackFactory. That right coop/Axel ?
No longer blocks: 488099
Blocks 3.5rc1 builds starting.
Blocks: 493957, 488099
Severity: normal → blocker
Would something like this work?
Attachment #379382 - Flags: review?(nthomas)
It works in the sense of not stalling slaves, from the first chunk of the patch. But it mangles the printing of all the properties except tree. Eg
 http://staging-master.build.mozilla.org:8010/builders/linux_repack/builds/1522
has 
 echo TinderboxPrint: buildnumber: <buildbot.process.properties.WithProperties instance at 0xa67230c>
This works fine in staging, and is similar to what we do in dev builds. I'm not sure if setting it on the scheduler is strictly necessary though.
Assignee: nobody → nthomas
Attachment #379382 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #379426 - Flags: review?(catlee)
Attachment #379382 - Flags: review?(nthomas)
Attachment #379426 - Flags: review+
Comment on attachment 379426 [details] [diff] [review]
Provided a tree definition for releases

Looks good to me.
PS: The right place to set the default would have been in DependentL10n, setting it to "notset" or something instead of None.
Attachment #379426 - Flags: review?(catlee)
Comment on attachment 379426 [details] [diff] [review]
Provided a tree definition for releases

catlee said this looked fine on IRC.

committed changeset 1167:531256cb3b6a

production-master reconfig'd
Attachment #379426 - Flags: checked‑in+
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.