Closed Bug 494677 Opened 11 years ago Closed 11 years ago

Port 'package-tests' build target to comm-central

Categories

(MailNews Core :: Build Config, enhancement)

enhancement
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.9.1

People

(Reporter: sgautherie, Assigned: sgautherie)

References

()

Details

Attachments

(1 file)

See bug 464707 as an example.
Flags: in-testsuite-
Last I checked (TB, reftest & crashtest), this command worked without issue. Did something change?
Mark, it doesn't work at the toplevel of my objdir, I guess it works in the mozilla/ subdir of it though. That means we need to forward it from our toplevel to the mozilla Makefile, like a number of other targets.
Ok, you do have to run it from the <objdir>/mozilla. It packages at least the mailnews xpcshell-tests, and I guess SeaMonkey's browser test files as well (though I haven't checked that).

So I guess what we need is a way to do comm-central specific packaging for tests (which I'm going to be looking at for bloat tests at least) hooking in with the mozilla-central method - although in the first instance just forwarding the target would probably be enough.
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.2a1pre) Gecko/20090518 SeaMonkey/2.0b1pre] (experimental/_m-c_, home, optim default) (W2Ksp4)
(http://hg.mozilla.org/mozilla-central/rev/a7c0b3588242
 +http://hg.mozilla.org/comm-central/rev/6786ebf24275 + bug 493008 patches)

Trivial :-)
Attachment #379565 - Flags: review?(kairo)
(In reply to comment #3)
> I guess SeaMonkey's browser test files as well (though I haven't checked that).

It seems to do that too :-)

> in the first instance just forwarding the target would probably be enough.

Agreed, we can revisit this in a follow-up bug ;-)
Summary: Port 'package-tests' build target to comm-central apps → Port 'package-tests' build target to comm-central
Target Milestone: mozilla1.9.1 → mozilla1.9.2a1
Attachment #379565 - Flags: review?(kairo) → review+
Comment on attachment 379565 [details] [diff] [review]
(Av1) Forward target
[Checkin: Comment 6]


http://hg.mozilla.org/comm-central/rev/a5197462fd29
Attachment #379565 - Attachment description: (Av1) Forward target → (Av1) Forward target [Checkin: Comment 6]
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: mozilla1.9.2a1 → mozilla1.9.1
You need to log in before you can comment on or make changes to this bug.