Closed Bug 494683 Opened 11 years ago Closed 10 years ago

warning: comparison between signed and unsigned and incorrect initialization order

Categories

(Core :: DOM: Core & HTML, defect, minor)

defect
Not set
minor

Tracking

()

RESOLVED FIXED

People

(Reporter: timeless, Assigned: timeless)

Details

Attachments

(1 file, 1 obsolete file)

content/base/src/nsDocumentEncoder.cpp: In member function ‘nsresult nsDocumentEncoder::SerializeRangeNodes(nsIDOMRange*, nsIDOMNode*, nsAString_internal&, PRInt32)’:
content/base/src/nsDocumentEncoder.cpp:674: warning: comparison between signed and unsigned integer expressions
content/base/src/nsDocumentEncoder.cpp:678: warning: comparison between signed and unsigned integer expressions
content/html/content/src/nsHTMLSelectElement.cpp: In member function ‘virtual nsresult nsHTMLSelectElement::SetLength(PRUint32)’:
content/html/content/src/nsHTMLSelectElement.cpp:746: warning: comparison between signed and unsigned integer expressions
content/base/src/nsPlainTextSerializer.cpp: In member function ‘void nsPlainTextSerializer::AddToLine(const PRUnichar*, PRInt32)’:
content/base/src/nsPlainTextSerializer.cpp:1389: warning: comparison between signed and unsigned integer expressions
content/base/src/nsSyncLoadService.cpp: In static member function ‘static nsresult nsSyncLoadService::PushSyncStreamToListener(nsIInputStream*, nsIStreamListener*, nsIChannel*)’:
content/base/src/nsSyncLoadService.cpp:467: warning: comparison between signed and unsigned integer expressions
content/base/src/nsXMLContentSerializer.cpp: In member function ‘virtual void nsXMLContentSerializer::IncrIndentation(nsIAtom*)’:
content/base/src/nsXMLContentSerializer.cpp:1303: warning: comparison between signed and unsigned integer expressions
content/base/src/nsXMLContentSerializer.cpp: In member function ‘virtual void nsXMLContentSerializer::AppendToStringFormatedWrapped(const nsASingleFragmentString&, nsAString_internal&)’:
content/base/src/nsXMLContentSerializer.cpp:1646: warning: comparison between signed and unsigned integer expressions
content/html/content/src/nsHTMLMediaElement.cpp: In member function ‘already_AddRefed<nsIURI> nsHTMLMediaElement::GetNextSource()’:
content/html/content/src/nsHTMLMediaElement.cpp:1647: warning: comparison between signed and unsigned integer expressions
content/events/src/nsDOMDataTransfer.h: In constructor ‘nsDOMDataTransfer::nsDOMDataTransfer()’:
content/events/src/nsDOMDataTransfer.h:194: warning: ‘nsDOMDataTransfer::mDragImageY’ will be initialized after
content/events/src/nsDOMDataTransfer.h:171: warning:   ‘PRPackedBool nsDOMDataTransfer::mCursorState’
content/events/src/nsDOMDataTransfer.cpp:71: warning:   when initialized here
Attached patch patch (obsolete) — Splinter Review
Attachment #379447 - Flags: superreview?
Attachment #379447 - Flags: review?
Attachment #379447 - Flags: superreview?(jst)
Attachment #379447 - Flags: superreview?
Attachment #379447 - Flags: review?(jst)
Attachment #379447 - Flags: review?
Attachment #379447 - Flags: superreview?(jst)
Attachment #379447 - Flags: superreview+
Attachment #379447 - Flags: review?(jst)
Attachment #379447 - Flags: review+
patching file content/events/src/nsDOMDataTransfer.cpp
Hunk #1 FAILED at 71

patching file content/html/content/src/nsHTMLMediaElement.cpp
Hunk #1 FAILED at 1643
Keywords: checkin-needed
OS: Mac OS X → All
Hardware: x86 → All
Attachment #379447 - Attachment is obsolete: true
Whiteboard: [timeless: needs unrotted patch]
Attachment #431815 - Flags: review+
Whiteboard: [timeless: needs unrotted patch]
http://hg.mozilla.org/mozilla-central/rev/b193d3213d41
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.