Closed Bug 494686 Opened 10 years ago Closed 8 years ago
Layout warning: comparison between signed and unsigned
layout/generic/nsFrameSetFrame.cpp: In member function ‘void nsHTMLFramesetFrame::RecalculateBorderResize()’: layout/generic/nsFrameSetFrame.cpp:1410: warning: comparison between signed and unsigned integer expressions layout/generic/nsSelection.cpp: In member function ‘PRBool nsTypedSelection::EqualsRangeAtPoint(nsINode*, PRInt32, nsINode*, PRInt32, PRInt32)’: layout/generic/nsSelection.cpp:4061: warning: comparison between signed and unsigned integer expressions
Comment on attachment 379449 [details] [diff] [review] patch The frameset change looks fine. For the other, I'd prefer combining the first two ifs, and replacing the |if (x) return PR_TRUE; else return PR_FALSE;| pattern with |return x;|
I don't see any such warning in linux gcc4.6. Hence closing the bug.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.