Closed
Bug 494686
Opened 16 years ago
Closed 13 years ago
Layout warning: comparison between signed and unsigned
Categories
(Core :: Layout, defect)
Tracking
()
RESOLVED
WORKSFORME
People
(Reporter: timeless, Assigned: timeless)
References
(Blocks 1 open bug)
Details
(Whiteboard: [build_warning])
Attachments
(1 file)
1.73 KB,
patch
|
bzbarsky
:
review-
bzbarsky
:
superreview-
|
Details | Diff | Splinter Review |
layout/generic/nsFrameSetFrame.cpp: In member function ‘void nsHTMLFramesetFrame::RecalculateBorderResize()’:
layout/generic/nsFrameSetFrame.cpp:1410: warning: comparison between signed and unsigned integer expressions
layout/generic/nsSelection.cpp: In member function ‘PRBool nsTypedSelection::EqualsRangeAtPoint(nsINode*, PRInt32, nsINode*, PRInt32, PRInt32)’:
layout/generic/nsSelection.cpp:4061: warning: comparison between signed and unsigned integer expressions
Attachment #379449 -
Flags: superreview?(bzbarsky)
Attachment #379449 -
Flags: review?(bzbarsky)
![]() |
||
Comment 2•16 years ago
|
||
Comment on attachment 379449 [details] [diff] [review]
patch
The frameset change looks fine.
For the other, I'd prefer combining the first two ifs, and replacing the |if (x) return PR_TRUE; else return PR_FALSE;| pattern with |return x;|
Attachment #379449 -
Flags: superreview?(bzbarsky)
Attachment #379449 -
Flags: superreview-
Attachment #379449 -
Flags: review?(bzbarsky)
Attachment #379449 -
Flags: review-
Updated•14 years ago
|
Whiteboard: [build_warning]
Updated•14 years ago
|
Blocks: buildwarning
Comment 3•13 years ago
|
||
I don't see any such warning in linux gcc4.6.
Hence closing the bug.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → WORKSFORME
You need to log in
before you can comment on or make changes to this bug.
Description
•