494838 - about:privatebrowsing / about:sessionrestore favicon gets reset when pressing Esc while focus is in the location bar

Status: VERIFIED FIXED

(Firefox :: General, defect)

Description

[(no longer active)]

STR:

1. Enter the private browsing mode.  The cursor should be in the location bar.
2. Press Esc.

Comment 1

[(no longer active)]

Another manifestation:

1. Open about:privatebrowsing in a new tab.
2. Detach the tab to a new window.  At this point, no favicon is displayed.

Also:

1. Open about:privatebrowsing in a new tab.
2. Drag the tab to another window.  At this point, no favicon is displayed.

This is a regression from bug 

Patch forthcoming.

Comment 2

[(no longer active)]

Attachment: Patch (v1)

It turns out that the affect of |value| on validity check should also be taken into account for about:blank, not for the rest of the initial pages.

Comment 3

[(no longer active)]

Asking wanted based on the use cases in comment 1.

Comment 4

[Dão Gottwald [:dao]]

Comment on attachment 379716 [details] [diff] [review]
Patch (v1)

>+    var isBlank = (uri.spec == "about:blank");

let, please?

Comment 5

[(no longer active)]

Attachment: Patch (v1.1)

(In reply to comment #4)
> (From update of attachment 379716 [details] [diff] [review])
> >+    var isBlank = (uri.spec == "about:blank");
> 
> let, please?

Sure.

Comment 6

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/c8dcfbbd2a44

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Verified fixed on trunk with builds on all platforms like Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090527 Minefield/3.6a1pre ID:20090527031500

Comment 8

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 379719 [details] [diff] [review]
Patch (v1.1)

a191=beltzner

Comment 9

[(no longer active)]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/fde8af305fc6

Comment 10

[Marcia Knous [:marcia]]

While trying to verify this on 1.9.1 I had some instances where the icon once again disappeared - this was primarily seen using Win XP. In the case where I most recently saw it here is what I did:

1. Enter PB using the tools menu.
2. Used the new tab button to create a blank tab.
3. Switched back to about: PB tab and the icon was blank.

The problem is that I cannot get this happen consistently.

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Verified fixed on 1.9.1 with builds on all platforms like Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1pre) Gecko/20090528 Shiretoko/3.5pre ID:20090528031233

Marcia, I cannot see this problem you mentioned. If you will ever be able to reproduce it please file a new bug. Thanks.

This icon is very noticable for each of our nightly testers. I don't think that we should create a new Litmus test for it. Marcia, can we just include the icon part in any existing test? Just for quick verification.

Comment 12

[Marcia Knous [:marcia]]

I think a test case is worth it since I think Ehsan wants to test that after you open new tabs etc that it still show. I will create a test case.

Comment 13

[(no longer active)]

(In reply to comment #12)
> I think a test case is worth it since I think Ehsan wants to test that after
> you open new tabs etc that it still show. I will create a test case.

Agreed. Thanks!

Comment 14

[u279076]

Existing testcase should be sufficient:
https://litmus.mozilla.org/show_test.cgi?id=11316