Closed Bug 494884 Opened 15 years ago Closed 15 years ago

Cmd + r reloads page and open new tab

Categories

(Firefox :: Keyboard Navigation, defect)

Product:
Firefox
Component:
Keyboard Navigation
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: trg16, Assigned: jmgregory)

References

(
URL
)

Details

(Keywords: fixed1.9.1, regression) 

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1pre) Gecko/20090526 Shiretoko/3.5pre
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1pre) Gecko/20090526 Shiretoko/3.5pre

When on a blog page (example) with an embedded flash video (youtube and others also) I click on video so it will open in another tab, then I go back to the blog page and reload it to stop the video caching since it's been loaded on the other tab. But when reloading (cmd + r, I'm on a mac) it will reload the page AND open the same page in another tab.

Reproducible: Always

Steps to Reproduce:
1.Open a page with flash video embedded;
2.Click to start the video;
3.Press cmd + r.
Actual Results:  
1.Reloads the page;
2.Opens the page in a new tab.

Expected Results:  
1.Reloads the page.

New test profile, no themes/extensions.
Confirmed using Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1pre) Gecko/20090526 Shiretoko/3.5pre

Can anyone find a regression window as I don't have time at the moment?
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: blocking-firefox3.5?
Don't know if this helps you, but it does not happen on 3.5b4.
I can't reproduce this on youtube. I'm:

1) Go to youtube.com
2) Click one of the featured videos
3) Once it's playing, hitting Cmd-R

I see the page reload, but no new tab.

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1pre) Gecko/20090526 Shiretoko/3.5pre

but this is my own build, built up to changeset - 731679c1ff39
That's on Shockwave Flash 10.0 r22, btw.
What version of Flash do you have, brassen?
Flags: blocking-firefox3.5? → blocking-firefox3.5+
This occurs for me using Shockwave Flash 10.0 r22 (aka 10.0.22.87)
Latest flash (have reinstalled it to check). 10,0,22,87

It does not happen on Youtube.com. Only in pages with embedded flash videos. 

Try any blogs like Gizmodo, Engadget, etc, like http://jalopnik.com/5263651/drawing-awesome-hot-rod-sleds-on-a-nintendo-ds

happens 100% of time.
(In reply to comment #7)
> Latest flash (have reinstalled it to check). 10,0,22,87
> 
> It does not happen on Youtube.com. Only in pages with embedded flash videos. 
> 
> Try any blogs like Gizmodo, Engadget, etc, like
> http://jalopnik.com/5263651/drawing-awesome-hot-rod-sleds-on-a-nintendo-ds
> 
> happens 100% of time.

This also happens for me on Youtube videos. I'm not sure why it is for me but not for others but it seems to be reproducable here.
Just found out this site:

http://www.adobe.com/software/flash/about/

there's a flash animation that checks what version you have installed. Cmd + r will reload and open the new tab...

maybe a flash plugin bug...

Note that on that page, if you click on the http://address (select the address) and hit cmd + r it only reloads the page (normal behavior)

*sorry for my english
(In reply to comment #7)
> Latest flash (have reinstalled it to check). 10,0,22,87
> 
> It does not happen on Youtube.com. Only in pages with embedded flash videos. 
> 
> Try any blogs like Gizmodo, Engadget, etc, like
> http://jalopnik.com/5263651/drawing-awesome-hot-rod-sleds-on-a-nintendo-ds
> 
> happens 100% of time.

With that link, I confirm that I see the behaviour described.
To help with the regression window, my first post about this on MozillaZine build forum was on May 20th. 
So, for at least a half week before that it appeared. I'm guessing you guys should look for between the 3.5b4 release and May 16th.
Can anyone try with an earlier Flash?
I've asked Curtis to try to chase down a regression range here.
This is a bit similar to bug 494356.
The bug appears to have been introduced in:

changeset:   25111:5d3dc9101db5
user:        Justin Gregory <jmgregory@gmail.com>
date:        Sat Apr 25 20:15:42 2009 +1200
summary:     Bug 490002. Set correct keyboard modifiers in native OS X menu command event. r=joshmoz,sr=roc
Keywords: regressionwindow-wanted
Adding some CC's based on comment 15 - thanks Curtis!

justin/josh - any thoughts here?  Bug 490002, if it is indeed the culprit, was a non-blocking polish bug, whereas this bug is a blocker. Is a low-risk fix apparent to one of you, or do we back out on bug 490002 on 191?
Blocks: 490002
My thought is that we back bug 490002 out of mozilla-1.9.1 and see if that fixes this issue. Once that's done, we can decide if we also want it backed out of mozilla-central, or just fix the regression there.
I agree, we should do that.  Bug 490002 is one that we could take in 3.5.x when we figure it out, and it's not a blocker.
I see the bug too, now that I've upgraded from Flash 9 to Flash 10.  Back out bug 490002 if you need to; I'll start working on a patch.
Thanks, Justin.  Backed out on branch.

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/0e17edad9641
Assignee: nobody → jmgregory
Keywords: fixed1.9.1
Bug 490002 has been backed out on trunk too, now.  I think we can mark this bug fixed.

http://hg.mozilla.org/mozilla-central/rev/993a4c7e44af
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
To add some context about the right way to fix this in the long run... Flash shouldn't be doing this but we don't give them any good alternative for playing nice with commands like cmd-r to reload. Once we fix bug 491141, add support for Advanced Key Handling, they can just reject the event and we'll handle the key press on our own.
No longer blocks: 490002
You need to log in before you can comment on or make changes to this bug.