495048 - clean up progress dialog prefs

Status: RESOLVED FIXED

(SeaMonkey :: Download & File Handling, defect)

Description

[Robert Kaiser]

I just noticed that the browser.download.progressDnldDialog.* default prefs are still around after my bug 483241 patch but are not used any more. We should probably just kill them.

Comment 1

[Robert Kaiser]

I'll change the keep/close bool pref to browser.download.progress.closeWhenDone to fit with the download manager one and hope to get this in with the big dlmgr landing.

Comment 2

[Robert Kaiser]

Attachment: progress pref cleanup

This patch goes on top of the whole download manager patch stack. Taking advantage of the fact that this stack isn't in yet, here's a patch to migrate the "keep open" pref to .progress.closeWhenDone to match the download manager pref of the same name, to use it in the progress windows and to kill the other old progress dialog prefs.

Comment 3

[[e-mail]]

Comment on attachment 380010 [details] [diff] [review]
progress pref cleanup

>+    try {
>+      prefs.setIntPref("browser.download.progress.closeWhenDone",
>+                       !prefs.getBoolPref("browser.download.progressDnldDialog.keepAlive"));
>+    } catch (e) {}
;-) but you're supposed to be setting a Bool pref :-P

Comment 4

[Robert Kaiser]

Pushed as http://hg.mozilla.org/comm-central/rev/bc99f3297a18