Closed Bug 495048 Opened 15 years ago Closed 15 years ago

clean up progress dialog prefs

Categories

(SeaMonkey :: Download & File Handling, defect)

defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.0b1

People

(Reporter: kairo, Assigned: kairo)

References

Details

Attachments

(1 file)

I just noticed that the browser.download.progressDnldDialog.* default prefs are still around after my bug 483241 patch but are not used any more. We should probably just kill them.
I'll change the keep/close bool pref to browser.download.progress.closeWhenDone to fit with the download manager one and hope to get this in with the big dlmgr landing.
Assignee: nobody → kairo
Status: NEW → ASSIGNED
Summary: now-unused progress dialog prefs are still around → clean up progress dialog prefs
This patch goes on top of the whole download manager patch stack. Taking advantage of the fact that this stack isn't in yet, here's a patch to migrate the "keep open" pref to .progress.closeWhenDone to match the download manager pref of the same name, to use it in the progress windows and to kill the other old progress dialog prefs.
Attachment #380010 - Flags: review?(neil)
Comment on attachment 380010 [details] [diff] [review]
progress pref cleanup

>+    try {
>+      prefs.setIntPref("browser.download.progress.closeWhenDone",
>+                       !prefs.getBoolPref("browser.download.progressDnldDialog.keepAlive"));
>+    } catch (e) {}
;-) but you're supposed to be setting a Bool pref :-P
Attachment #380010 - Flags: review?(neil) → review+
Pushed as http://hg.mozilla.org/comm-central/rev/bc99f3297a18
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.0b1
You need to log in before you can comment on or make changes to this bug.