Closed
Bug 49510
Opened 24 years ago
Closed 24 years ago
[MLK] MRJ Plugin lifetime problems
Categories
(Core Graveyard :: Java: OJI, defect, P2)
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla0.9
People
(Reporter: beard, Assigned: beard)
References
Details
(Keywords: memory-leak, Whiteboard: [nsbeta3-] [PDTP2] fixes checked in, awaiting fix for 45009)
Attachments
(1 file)
3.62 KB,
patch
|
Details | Diff | Splinter Review |
The MRJ plugin does some skanky stuff when shutting down, that can cause crashes. In addition, it doesn't properly release reference counts to the service manager, and other services. The enclosed patches make an attempt to fix these problems. However, the Plugins system itself will need to be fixed to call the nsIPlugin::Shutdown() method to cause proper shutdown.
Assignee | ||
Updated•24 years ago
|
Assignee | ||
Comment 1•24 years ago
|
||
Comment 2•24 years ago
|
||
adding dependency on bug 45009: nsIPlugin::Initialize() and ::Shutdown aren't called
Assignee | ||
Comment 4•24 years ago
|
||
I don't own this component, George, would you please consider this for nsbeta3?
Assignee | ||
Comment 5•24 years ago
|
||
Checking in lifetime fixes. It's now or never.
Whiteboard: [nsbeta3+]
Assignee | ||
Comment 6•24 years ago
|
||
Fixes for lifetime issues are checked in, but can't close this bug until 45009 is resolved.
Status: NEW → ASSIGNED
Sorry, Patrick: was on vacation last week. I'll have Ed Burns look at your proposed patch (we're trying to figure this out for Win32 as well), and looks like you already took care of the nomination.
Assignee | ||
Updated•24 years ago
|
Whiteboard: [nsbeta3+] → [nsbeta3+] fixes checked in, awaiting fix for 45009
Assignee | ||
Comment 9•24 years ago
|
||
This is a correctness issue, but only rears its head at application shutdown.
Priority: P3 → P2
Updated•24 years ago
|
Whiteboard: [nsbeta3+] fixes checked in, awaiting fix for 45009 → [nsbeta3+] [PDTP2] fixes checked in, awaiting fix for 45009
Comment 10•24 years ago
|
||
PDT agrees P2
Comment 11•24 years ago
|
||
I don't see anything in here which sounds like a PR3 stopper, so marking nsbeta3-. Also adding the rtm keyword so the patch can be considered for the branch before Seamonkey RTM.
Whiteboard: [nsbeta3+] [PDTP2] fixes checked in, awaiting fix for 45009 → [nsbeta3-] [PDTP2] fixes checked in, awaiting fix for 45009
Assignee | ||
Comment 12•24 years ago
|
||
These fixes were already checked in, so just waiting for 45009 to close and verify.
Assignee | ||
Updated•24 years ago
|
Target Milestone: --- → M18
Updated•24 years ago
|
OS: All
Target Milestone: M18 → ---
Comment 14•24 years ago
|
||
Av is waiting for sr=waterson on 45009.
Assignee | ||
Comment 15•24 years ago
|
||
The plugin methods Shutdown() and ShutdownJVM() still aren't getting called with the latest tip build. I'm currently testing LiveConnect which doesn't actually create an nsIPluginInstance, just an nsIPlugin. So, there are still bugs in the plugin code.
Target Milestone: --- → mozilla0.9
Assignee | ||
Comment 16•24 years ago
|
||
This appears to be fixed with latest checkins.
Comment 17•24 years ago
|
||
can we get it marked fixed....? thanks
Assignee | ||
Comment 18•24 years ago
|
||
I believe this is now fixed.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•