Closed Bug 495103 Opened 14 years ago Closed 14 years ago

NSS_InitReadWrite("sql:<dbdir>") causes NSS to look for "sql:<dbdir>/libnssckbi.so"

Categories

(NSS :: Libraries, defect, P1)

Product:
NSS
Component:
Libraries
Version:
3.12
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
3.12.4

People

(Reporter: wtc, Assigned: wtc)

Details

Attachments

(1 file)

Proposed patch
1.50 KB, patch
rrelyea
: review+
Details | Diff | Splinter Review
Attached patch Proposed patch — — Splinter Review 
If I call NSS_InitReadWrite("sql:<dbdir>"), with the "sql:" prefix,
nss_FindExternalRoot calls SECMOD_AddNewModule with the wrong pathname
"sql:<dbdir>/libnssckbi.so".

We should strip the "sql:" prefix from the pathname, so that
nss_FindExternalRoot calls SECMOD_AddNewModule with
"<dbdir>/libnssckbi.so".  The attached patch strips "sql:" in nss_Init,
but we could also do that in nss_FindExternalRoot or
nss_FindExternalRootPaths.
Attachment #379939 - Flags: review?(rrelyea)
Attachment #379939 - Flags: review?(rrelyea) → review+
Comment on attachment 379939 [details] [diff] [review]
Proposed patch

r+ rrelyea
Priority: -- → P1
Version: unspecified → 3.12
I checked in the patch on the NSS trunk (NSS 3.12.4).

Checking in nssinit.c;
/cvsroot/mozilla/security/nss/lib/nss/nssinit.c,v  <--  nssinit.c
new revision: 1.98; previous revision: 1.97
done
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.