495145 - Pausing a video after |ended| fires prevents starting playback again

Status: VERIFIED FIXED

(Core :: Audio/Video, defect)

Description

[Justin Dolske [:Dolske]]

If a video is paused after |ended| fires, attempting to play it again results in it firing a |waiting| event but no playback ever begins (the video controls show a throbber during this state). Seeking to any point in the video will make it start working, however.

1) Make a little HTML test case with a video and a button:
<button onclick="document.getElementById('vid').pause();">BreakMe</button>
2) Play the video, optionally seek near the end, wait for it to finish.
3) Click the BreakMe button from step 1.
4) Click the video's play button.

Actual results:
No playback, infinite throbber.

Expected results:
Playback should restart from the beginning of the video.

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I have a fix.

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

Fix. While in the ENDED state, we should stay there even if Pause() is called.

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Should perhaps block since this is easily seen with the current firstrun page

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Eh, I'll make this block so I can land it.

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

http://hg.mozilla.org/mozilla-central/rev/0e2117eeaf4d

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Marking verified fixed on trunk for all platforms based on passed mochitests and the example on http://lachy.id.au/dev/markup/examples/video/0003

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090528 Minefield/3.6a1pre ID:20090528031326

Comment 7

[Mike Beltzner [:beltzner, not reading bugmail]]

Can we please get this landed ASAP on 1.9.1?

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/3454ed7b8859

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Verified fixed on 1.9.1 with builds on all platforms and attachment 346615 [details].

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1pre) Gecko/20090604 Shiretoko/3.5pre ID:20090604031153