Pausing a video after |ended| fires prevents starting playback again

VERIFIED FIXED in mozilla1.9.2a1

Status

()

defect
VERIFIED FIXED
10 years ago
10 years ago

People

(Reporter: Dolske, Assigned: roc)

Tracking

({verified1.9.1})

Trunk
mozilla1.9.2a1
Points:
---
Bug Flags:
blocking1.9.1 +
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

If a video is paused after |ended| fires, attempting to play it again results in it firing a |waiting| event but no playback ever begins (the video controls show a throbber during this state). Seeking to any point in the video will make it start working, however.

1) Make a little HTML test case with a video and a button:
<button onclick="document.getElementById('vid').pause();">BreakMe</button>
2) Play the video, optionally seek near the end, wait for it to finish.
3) Click the BreakMe button from step 1.
4) Click the video's play button.

Actual results:
No playback, infinite throbber.

Expected results:
Playback should restart from the beginning of the video.
I have a fix.
Assignee: nobody → roc
Posted patch fixSplinter Review
Fix. While in the ENDED state, we should stay there even if Pause() is called.
Attachment #380014 - Flags: review?(chris.double)
Should perhaps block since this is easily seen with the current firstrun page
Flags: blocking1.9.1?
Whiteboard: [needs review]
Attachment #380014 - Flags: review?(chris.double) → review+
Eh, I'll make this block so I can land it.
Flags: blocking1.9.1? → blocking1.9.1+
Whiteboard: [needs review] → [needs landing]
Flags: in-testsuite?
OS: Mac OS X → All
Hardware: x86 → All
http://hg.mozilla.org/mozilla-central/rev/0e2117eeaf4d
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [needs landing]
Flags: in-testsuite? → in-testsuite+
Marking verified fixed on trunk for all platforms based on passed mochitests and the example on http://lachy.id.au/dev/markup/examples/video/0003

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090528 Minefield/3.6a1pre ID:20090528031326
Status: RESOLVED → VERIFIED
Target Milestone: --- → mozilla1.9.2a1
Can we please get this landed ASAP on 1.9.1?
Whiteboard: [needs 1.9.1 landing]
Whiteboard: [needs 1.9.1 landing] → [needs 191 landing]
Verified fixed on 1.9.1 with builds on all platforms and attachment 346615 [details].

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1pre) Gecko/20090604 Shiretoko/3.5pre ID:20090604031153
You need to log in before you can comment on or make changes to this bug.