495226 - Update OpenSearch notification on the search engine button on Windows

Status: RESOLVED WONTFIX

(Firefox :: Theme, defect)

Description

[Alex Faaborg [:faaborg] (Firefox UX)]

Now that we have refreshed secondary glyphs for Windows, I think we should consider using the glowing hit state of 

/source/toolkit/themes/winstripe/global/arrow/arrow-down.png
/source/toolkit/themes/winstripe/global/arrow/arrow-down-aero.png

(added in bug 495218)

as a notification of OpenSearch instead of the current blue glow.  This is primarily an aesthetic change as opposed to an interactive change.  In this state the hit state would be the same as the normal state.

Comment 1

[Alex Faaborg [:faaborg] (Firefox UX)]

beltzner should ui-r since I proposed the change

Comment 2

[Alex Faaborg [:faaborg] (Firefox UX)]

Attachment: Mockup

Comment 3

[(no longer active)]

Attachment: Patch (v1)

I'll attach screenshots for beltzner's ui-r in a moment...

Comment 4

[(no longer active)]

Attachment: Screenshot (1:1)

Order of images from top to bottom:

1. Current normal drop-down arrow.
2. Patched normal drop-down arrow.
3. Current OpenSearch notification.
4. Patches OpenSearch notification.

Comment 5

[(no longer active)]

Attachment: Screenshot (100:1)

The same as attachment 380147 [details], scaled at 100x for better viewing of the details.

Comment 6

[Dão Gottwald [:dao]]

Ehsan, could you prepare a patch and before/after screenshots for ui-review on top of the patch in bug 495606? We shouldn't change the search dropdown without the location dropdown, so that's a hard dependency.

Comment 7

[(no longer active)]

Attachment: Patch based on bug 495606

Comment 8

[(no longer active)]

Attachment: Before/After screenshot

The "before" screenshots are in fact with bug 495606 applied.

Comment 9

[Dão Gottwald [:dao]]

Comment on attachment 381012 [details] [diff] [review]
Patch based on bug 495606

>-.searchbar-engine-button[open="true"] > .searchbar-dropmarker-image {
>+.searchbar-engine-button[addengines="true"] > .searchbar-dropmarker-image {
>   -moz-image-region: rect(0, 26px, 11px, 13px);
> }

I think it would make sense to still use the glowing arrow for the hit state, for consistency with the location dropdown and the all tabs button:

>.searchbar-engine-button[addengines="true"] > .searchbar-dropmarker-image,
>.searchbar-engine-button[open="true"] > .searchbar-dropmarker-image {
>  -moz-image-region: rect(0, 26px, 11px, 13px);
>}

fine by me either way.

Comment 10

[(no longer active)]

(In reply to comment #9)
> I think it would make sense to still use the glowing arrow for the hit state,
> for consistency with the location dropdown and the all tabs button:

Beltzner: please let us know which version you prefer.

Comment 11

[Alex Faaborg [:faaborg] (Firefox UX)]

Follow up bug for a similar change on OS X: bug 495745

Comment 12

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 381012 [details] [diff] [review]
Patch based on bug 495606

For the same reasons as mentioned in bug 495606 comment 8, not gonna take this on branch at this time.

Comment 13

[Dão Gottwald [:dao]]

Comment on attachment 381012 [details] [diff] [review]
Patch based on bug 495606

Given bug 482229, no point in taking it on trunk if it won't make 3.5.

Comment 14

[(no longer active)]

(In reply to comment #13)
> (From update of attachment 381012 [details] [diff] [review])
> Given bug 482229, no point in taking it on trunk if it won't make 3.5.

So, can I mark this as WONTFIX?

Comment 15

[Dão Gottwald [:dao]]

yep