Closed Bug 495347 Opened 16 years ago Closed 6 years ago

Add tests for stylesheet cloning to test_selector_in_html (in test_selectors.html)

Categories

(Core :: CSS Parsing and Computation, defect, P3)

Product:
Core
Component:
CSS Parsing and Computation
Platform:
x86
macOS
Type:
defect

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: bzbarsky, Assigned: dbaron)

References

Details

See bug 495274 comment 10. The problem is that cloning only happens when stylesheets are loaded via <link>; there's no way to trigger it using inline style. We could add a test for that if we could tell when the <link> is done loading (bug 185236) or if we were willing to load an entire document in test_selector_in_html and wait for it to load. I'm going to assume the former is preferable, but if the latter is ok, let me know.
Flags: in-testsuite?
Priority: -- → P2
Priority: P2 → P3
Note to self: each call to test_selector_in_html should record the arguments, then we can go through, build a big stylesheet, load it, etc. This is in addition to the existing test bits. Some refactoring required.

Never did get to this. emilio, are you interested in picking this up?

Assignee: bzbarsky → nobody
Flags: needinfo?(emilio)

Seems like dbaron took care of this in https://hg.mozilla.org/mozilla-central/rev/1243f242bc07165b4688768c3086f387ecb396e9? But let me know if that's not what this bug was about.

Assignee: nobody → dbaron
Status: NEW → RESOLVED
Closed: 6 years ago
Flags: needinfo?(emilio)
Resolution: --- → FIXED

That looks like it does address this bug. Perfect.

You need to log in before you can comment on or make changes to this bug.