Closed
Bug 495384
Opened 17 years ago
Closed 17 years ago
Call NSS_Initialize with NSS_INIT_NOROOTINIT
Categories
(Core :: Security: PSM, defect)
Core
Security: PSM
Tracking
()
RESOLVED
FIXED
mozilla1.9.3a1
People
(Reporter: wtc, Assigned: wtc)
Details
Attachments
(1 file)
|
2.06 KB,
patch
|
rrelyea
:
review+
KaiE
:
superreview+
|
Details | Diff | Splinter Review |
PSM should call NSS_Initialize with NSS_INIT_NOROOTINIT
instead of calling NSS_InitReadWrite or NSS_Init so that
it turns off the loading of the root certd module in nss_Init:
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/security/nss/lib/nss/nssinit.c&rev=1.97&mark=556-560#554
PSM loads the root certs module in its InstallLoadableRoots
function, so it doesn't need nss_Init to load the root certs
module. Furthermore, the system NSS in Ubuntu 8.04 has a
patch that causes nss_Init to load any nonexistent path
"<configdir>/libnssckbi.so" as "/usr/lib/nss/libnssckbi.so".
See the Debian NSS patch (attachment 331958 [details] [diff] [review]) in bug 448792.
Since "/usr/lib/nss/libnssckbi.so" can be successfully loaded,
nss_Init writes the nonexistent path "<configdir>/libnssckbi.so"
to secmod.db/pkcs11.txt.
Attachment #380366 -
Flags: superreview?(kaie)
Attachment #380366 -
Flags: review?(rrelyea)
Updated•17 years ago
|
Attachment #380366 -
Flags: review?(rrelyea) → review+
Comment 1•17 years ago
|
||
Comment on attachment 380366 [details] [diff] [review]
Proposed patch
r+ the code looks good, just convince the module owner;).
bob
Updated•17 years ago
|
Attachment #380366 -
Flags: superreview?(kaie) → superreview+
Comment 2•17 years ago
|
||
Comment on attachment 380366 [details] [diff] [review]
Proposed patch
r=kaie assuming you have tested that Mozilla applications (Firefox) still show the list of roots in cert manager with this patch.
| Assignee | ||
Comment 3•17 years ago
|
||
I did the test that kaie requested. I pushed the patch
to mozilla-central in patchset a9d2a6619efc:
http://hg.mozilla.org/mozilla-central/rev/a9d2a6619efc
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Target Milestone: mozilla1.9.2a1 → mozilla1.9.3a1
You need to log in
before you can comment on or make changes to this bug.
Description
•