Open
Bug 495447
Opened 15 years ago
Updated 2 years ago
Mime should use NS_ASSERTION/NS_ERROR instead of PR_ASSERT
Categories
(MailNews Core :: MIME, defect)
Tracking
(Not tracked)
NEW
People
(Reporter: Bienvenu, Unassigned)
Details
Attachments
(1 file)
11.89 KB,
patch
|
standard8
:
review+
standard8
:
superreview+
|
Details | Diff | Splinter Review |
PR_ASSERT exits the app, after screwing up the stack trace on Vista 64, at least, so it makes it much harder to track down mime errors for me, at least. This patch replaces some of them, including one that was making it hard for me to track down bug 495057.
Attachment #380430 -
Flags: superreview?(bugzilla)
Attachment #380430 -
Flags: review?(bugzilla)
Comment 1•15 years ago
|
||
Comment on attachment 380430 [details] [diff] [review] remove some of the PR_ASSERTS - checked in. > case MimeMultipartSignedPreamble: > case MimeMultipartSignedBodyFirstHeader: > case MimeMultipartSignedBodyHeaders: >- PR_ASSERT(0); /* How'd we get here? Oh well, fall through. */ >+ NS_ERROR("wrong state in parse child line"); /* How'd we get here? Oh well, fall through. */ nit: can you put the comment on the line before like you did in the next hunk.
Attachment #380430 -
Flags: superreview?(bugzilla)
Attachment #380430 -
Flags: superreview+
Attachment #380430 -
Flags: review?(bugzilla)
Attachment #380430 -
Flags: review+
Reporter | ||
Comment 2•15 years ago
|
||
Comment on attachment 380430 [details] [diff] [review] remove some of the PR_ASSERTS - checked in. I'll leave this open because there are still a bunch of PR_ASSERTS left
Attachment #380430 -
Attachment description: remove some of the PR_ASSERTS → remove some of the PR_ASSERTS - checked in.
Reporter | ||
Updated•14 years ago
|
Assignee: bienvenu → nobody
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•