495452 - Size of "Details" box in "Clear Recent History" dialog is not updated when window gets resized

Status: VERIFIED FIXED

(Firefox :: Private Browsing, defect)

Description

[Nikolay S. Frantsev]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1pre) Gecko/20090529 Shiretoko/3.5pre
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1pre) Gecko/20090529 Shiretoko/3.5pre

area under "Details" label should have flex="1" XUL property

Reproducible: Always

Steps to Reproduce:
1. open "Clear Recent History" dialog
2. open "Details"
3. resize window vertically
Actual Results:  
area under "Details" label is not resized (screenshot: http://people.mozilla.ru/shutnik/img/shots/2009-05-29-%5B20-56-15%5D.png)

Expected Results:  
area under "Details" should fill window vertically (screenshot: http://people.mozilla.ru/shutnik/img/shots/2009-05-29-%5B20-57-18%5D.png)

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Normally this window should not be resizable. But it is. As what I can see it is a general problem on Linux. All dialogs which are not resizable on OS X or Windows can be resized on Linux. Is this intended? Drew, do you know that?

Comment 2

[Drew Willcoxon :adw]

Attachment: patch v1

That is interesting.  I'm not sure if it's a problem or feature.  Anyway, this patch flexes the listbox.  This adds 1 or 2 rows of pixels to the bottom of the listbox on Pinstripe but has no visible effect on the other two themes, except that it fixes the issue described in this bug on Linux.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Alex, could you tell us please what's the expected behavior is on Linux? It's not only this dialog which suffers from the ability to resize windows/dialogs on Linux. It looks also weird with the preferences dialog itself. Would be nice to have a UX statement before we file a new bug on it. Thanks.

Comment 4

[Alex Faaborg [:faaborg] (Firefox UX)]

Not sure if this should be resizeable, but it doesn't hurt.  Let's just add the flex so that it still looks good after resize.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Alex, shall I file new bugs for other dialogs or not?

Comment 6

[Alex Faaborg [:faaborg] (Firefox UX)]

If I say they shouldn't be resizable, a bunch of linux jerks are going to start a big flame war.  But they really shouldn't be resizable because there isn't much point.  However, we are too close to freeze for me to really care either way.  Sorry for the non-answer.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Filed as bug 497401.

Comment 8

[Drew Willcoxon :adw]

johnath, any chance of review here?

Comment 9

[Johnathan Nightingale [:johnath]]

Comment on attachment 380568 [details] [diff] [review]
patch v1

This really shouldn't have taken so long, sorry about that, Drew.

Comment 10

[Drew Willcoxon :adw]

No worries, thanks Johnathan.

Comment 11

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/298d8c394fef

Comment 12

[Tyler Downer [He/Him]]

V with. Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.2a1pre) Gecko/20090807 Minefield/3.6a1pre (.NET CLR 3.5.30729) ID:20090807045043