Closed
Bug 495527
Opened 16 years ago
Closed 16 years ago
Fix up send later unit tests and create alertTestUtils.js resource
Categories
(MailNews Core :: Backend, defect)
MailNews Core
Backend
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 3.0b3
People
(Reporter: standard8, Assigned: standard8)
References
Details
Attachments
(1 file, 1 obsolete file)
|
30.34 KB,
patch
|
Bienvenu
:
review+
|
Details | Diff | Splinter Review |
I realised today that when I changed the interfaces for send in background, I didn't actually change the unit tests... which also didn't fail.
This patch:
- Updates the unit tests and adds a couple more checks to ensure the relevant functions are being called (and hence protect against missing future changes).
- Switches test_sendMessageLater2.js to use the asyncTestUtils.js
- Creates alertTestUtils.js and uses it for two tests. I've been meaning to do this for a while - basically it just makes hooking into prompts easier if needed on unit tests.
Attachment #380516 -
Flags: review?(bienvenu)
|
Assignee | |
Comment 1•16 years ago
|
||
This fixes the case in alertTestUtils.js where a function doesn't exist and it should therefore be calling do_throw. We need to use the typeof operator here as what we are testing is unbounded.
Attachment #380516 -
Attachment is obsolete: true
Attachment #381046 -
Flags: review?(bienvenu)
Attachment #380516 -
Flags: review?(bienvenu)
|
||
Comment 2•16 years ago
|
||
Comment on attachment 381046 [details] [diff] [review]
The fix v2
tests passed for me on windows...
Attachment #381046 -
Flags: review?(bienvenu) → review+
|
|
Assignee | |
Comment 3•16 years ago
|
||
Status: NEW → RESOLVED
Closed: 16 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•