495535 - Titlebar should be visible after app launch

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Madhava Enros [:madhava]]

Right now, when Fennec is launched, the first run page is shown with the titlebar scrolled off the top of the page.  This means that the chrome that tells the user what he/she is looking at, and is used to go elsewhere (which is like the first thing wanted), is not available.  The titlebar should not be scrolled off the top.

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Display the urlbar at first launch

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 383242 [details] [diff] [review]
Display the urlbar at first launch

We actually want this panTo to go away entirely.

The real problem here is that the "resize" event hasn't fired yet. So the toolbar/sidebars are not in the correct location. In fact, if we manually call BrowserUI.sizeControls(window.innerWidth, window.innerHeight), the toolbar goes in the right spot.

I just haven't fully thought about the downside to doing that.

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to comment #3)
> (From update of attachment 383242 [details] [diff] [review])
> We actually want this panTo to go away entirely.

Do you speak of the first one or the second one? :)

> The real problem here is that the "resize" event hasn't fired yet. So the
> toolbar/sidebars are not in the correct location. In fact, if we manually call
> BrowserUI.sizeControls(window.innerWidth, window.innerHeight), the toolbar goes
> in the right spot.

The window is not already show when the first select tab is fired, is that?

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to comment #4)
> (In reply to comment #3)
> > (From update of attachment 383242 [details] [diff] [review] [details])
> > We actually want this panTo to go away entirely.
> 
> Do you speak of the first one or the second one? :)

Both. We should not be doing any ws.panTo(...) in this function

> 
> > The real problem here is that the "resize" event hasn't fired yet. So the
> > toolbar/sidebars are not in the correct location. In fact, if we manually call
> > BrowserUI.sizeControls(window.innerWidth, window.innerHeight), the toolbar goes
> > in the right spot.
> 
> The window is not already show when the first select tab is fired, is that?

It's either not fully shown, or only partially shown. Either way, the "resize" event is not fired before this method is called the first time.  Add some dump()s in both places to see.

Comment 6

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Updated patch

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 383479 [details] [diff] [review]
Updated patch

Good enough for now

Comment 8

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
http://hg.mozilla.org/mobile-browser/rev/81bf1308a4e5

Comment 9

[Dão Gottwald [:dao]]

bugspam

Comment 10

[Carla Nadastean]

Retested bug with:
Mozilla/5.0 (Android; Linux armv7l; rv:10.0a1) Gecko/20111005 Firefox/10.0a1 Fennec/10.0a1
Device: Motorola Droid 2 (Android 2.3)

URLbar is visible after Fennec is launched. Bug is no longer reproducible.

Verifying.