Closed Bug 495583 Opened 15 years ago Closed 15 years ago

[SeaMonkey] Remove SUITE_USING_XPFE_DM remnants

Categories

(Toolkit :: Downloads API, defect)

Product:
Toolkit
Component:
Downloads API
Type:
defect
Priority:
Not set
Severity:
trivial

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.9.2a1

People

(Reporter: sgautherie, Assigned: mpk)

References

(
URL
)

Details

(Keywords: fixed1.9.1, Whiteboard: [fixed1.9.1b99])

Attachments

(1 file)

v1.0 m-c [Checkin: Comment 7 & 9]
146.50 KB, patch
neil
: review+
beltzner
: approval1.9.1+
Details | Diff | Splinter Review 
      No description provided.
Flags: in-testsuite-
Summary: Remove SUITE_USING_XPFE_DM remnants → [SeaMonkey] Remove SUITE_USING_XPFE_DM remnants
v1.0

Issues addressed in this patch:
- removed all occurrences of ifndef SUITE_USING_XPFE_DM (incl. endif)
- removed all occurrences of  ifdef SUITE_USING_XPFE_DM (up to endif)
- removed all references to xpfe/components/download-manager/.../Makefile
                         in toolkit/toolkit-makefiles.sh
- removed all of xpfe/components/download-manager/
Assignee: nobody → bugmail
Status: NEW → ASSIGNED
Attachment #380587 - Flags: review?(neil)
Now Callek will be unhappy as he wanted to do the honors ;-)
Attachment #380587 - Flags: review?(neil) → review+
Comment on attachment 380587 [details] [diff] [review]
v1.0   m-c
[Checkin: Comment 7 & 9]

Shush! By the time he gets his Internet access back he may have forgotten ;-)
Then let's get this landed and blame it on the fairies. ;-)
Keywords: checkin-needed
Comment on attachment 380587 [details] [diff] [review]
v1.0   m-c
[Checkin: Comment 7 & 9]

This is not blocking, (nor landed on trunk (yet),)
but would be a nice removal...
Attachment #380587 - Flags: approval1.9.1?
Whiteboard: [c-n: v1.0 to m-c after m-1.9.1 freeze]
Comment on attachment 380587 [details] [diff] [review]
v1.0   m-c
[Checkin: Comment 7 & 9]

a191=beltzner, this all looks NPOTB and ifdef'd out to me, right?
Attachment #380587 - Flags: approval1.9.1? → approval1.9.1+
Comment on attachment 380587 [details] [diff] [review]
v1.0   m-c
[Checkin: Comment 7 & 9]


http://hg.mozilla.org/mozilla-central/rev/30b3e37776f9
Attachment #380587 - Attachment description: v1.0 m-c → v1.0 m-c [Checkin: Comment 7]
(In reply to comment #6)
> this all looks NPOTB and ifdef'd out to me, right?

Right, but KaiRo suggested me to ask anyway...
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Whiteboard: [c-n: v1.0 to m-c after m-1.9.1 freeze] → [needs 1.9.1 landing]
Target Milestone: --- → mozilla1.9.2a1
Comment on attachment 380587 [details] [diff] [review]
v1.0   m-c
[Checkin: Comment 7 & 9]


http://hg.mozilla.org/releases/mozilla-1.9.1/rev/d39c1c3f58aa
Attachment #380587 - Attachment description: v1.0 m-c [Checkin: Comment 7] → v1.0 m-c [Checkin: Comment 7 & 9]
Keywords: checkin-needed → fixed1.9.1
Whiteboard: [needs 1.9.1 landing] → [fixed1.9.1rc1]
Whiteboard: [fixed1.9.1rc1] → [fixed1.9.1b99]
Depends on: 467524
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: