Closed Bug 495647 Opened 17 years ago Closed 17 years ago

undefined reference to `nsWifiMonitor::DoScan()' in Qt build

Categories

(Core :: DOM: Geolocation, defect)

x86
Linux
defect
Not set
normal

Tracking

()

RESOLVED DUPLICATE of bug 487861

People

(Reporter: kairo, Unassigned)

References

Details

Attachments

(1 file)

This is in an --enable-default-toolkit=cairo-qt build: ../wifi/src/libneckowifi_s.a(nsWifiMonitor.o): In function `nsWifiMonitor::Run()': nsWifiMonitor.cpp:(.text+0x19): undefined reference to `nsWifiMonitor::DoScan()' /usr/lib/gcc/i586-suse-linux/4.4/../../../../i586-suse-linux/bin/ld: libnecko.so: hidden symbol `nsWifiMonitor::DoScan()' isn't defined /usr/lib/gcc/i586-suse-linux/4.4/../../../../i586-suse-linux/bin/ld: final link failed: Nonrepresentable section on output collect2: ld returned 1 exit status gmake[6]: *** [libnecko.so] Error 1 gmake[6]: Leaving directory `/mnt/mozilla/build/seamonkey-qt/mozilla/netwerk/build' Dolske requested in bug 479898 comment #15 with no obvious reason that nsWifiScannerUnix.cpp should be wrapped in a ifdef checking for GTK, which makes everyone not cocoa, windows or gtk2 without an implementation and with a failure to link necko. Is there _anything_ in nsWifiScannerUnix.cpp that is GTK-specific? If yes, then the name is wrong and it needs to be nsWifiScannerGTK.cpp, and if no, the ifdef wrapping it is wrong.
Depends on: 479898
If we don't we have any non-(MOZ_WIDGET_TOOLKIT=cocoa), non-(MOZ_WIDGET_TOOLKIT=windows), non-unix system for which we have any support in the tree, then it's probably still right to not test for toolkit on that else and assume it's unix. AFAIK, that what we're doing all over the place.
The assumption that all unix (we have in the tree) is GTK is surely wrong, the assumption this patch takes (i.e. non-mac non-windows is unix) is taken all across the tree from what I know and I haven't heard that it wouldn't be true at least within our tree (OS/2 is Windows in terms of toolkit, right?).
Assignee: nobody → kairo
Status: NEW → ASSIGNED
Attachment #380655 - Flags: review?(dolske)
won't this break non-window, non-mac, non-linux? (such as os2 and photon). clearly we still branch on photon and os2: http://mxr.mozilla.org/mozilla-central/search?string=%28MOZ_WIDGET_TOOLKIT%29,
(In reply to comment #3) > won't this break non-window, non-mac, non-linux? (such as os2 and photon). It's broken anyways, as compiling necko should fail right now for them in the same way Qt fails. It's very much possible that the ifdefs here should be for platforms, not for toolkits. I'm probably not in a position to figure out what is the right thing to do here, as I have no clue what assumptions the nsWifiScanner*.cpp make about where they can run and what the right ifdef is to take that into account, seems like MOZ_WIDGET_TOOLKIT just might not be what we want there. And maybe there needs to be a nsWifiScannerStub.cpp or so that is included for the platforms we don't have actual code for and which just stubs out the actual functionality.
Assignee: kairo → nobody
Component: Networking → Geolocation
QA Contact: networking → geolocation
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → DUPLICATE
Attachment #380655 - Flags: review?(dolske)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: