49565 - MLK: nsMsgFilterService::SaveFilterList()

Status: VERIFIED FIXED

(MailNews Core :: Filters, defect, P3)

Description

[Bruce Mitchener]

nsMsgFilterService::SaveFilterList() allocates tmpFileStream .. but never 
deletes it.

Comment 1

[scottputterman]

moving to future milestone.

Comment 2

[Bruce Mitchener]

This only requires the addtion of a 'delete tmpFileStream;' after line 117 
(tmpFileStream->close();)

Please reconsider futuring this.

Comment 3

[Kevin Higgins]

Attachment: Proposed patch.

Comment 4

[Kevin Higgins]

Propsed patch above.  1 line addition - as what bruce suggested.  Can I get a
review?

cc'ing myself.

Comment 5

[Alec Flett]

delete, then set it to null, then it's r=alecf

Comment 6

[Kevin Higgins]

Attachment: Patch, setting tmpFileStream to null

Comment 7

[Brendan Eich [:brendan]]

a=[e-mail]

/be

Comment 8

[Kevin Higgins]

Alec, can you check this in for me?  I don't have CVS write access.

Comment 9

[Alec Flett]

r=alecf
adding patch keyword so I remember to get this in my next patch checkin sweep

Comment 10

[Alec Flett]

reassigning my filter bugs to gayatrib..

Comment 11

[Kevin Higgins]

gayatrib, can this be checked in anytime soon?

Comment 12

[Håkan Waara]

There is a patch attached to this bug, which is ready for checkin. Gayatri,
can't you take this patch and just do it?

Comment 13

[timeless]

Attachment: better patch, use nsCOMPtr

Comment 14

[scottputterman]

reassigning to naving

Comment 15

[Håkan Waara]

Taking bug.

I will update Kevin's patch against the current tree and check it in.

Comment 16

[Håkan Waara]

Ok, patch applied in my tree.

I will check it in with sr=blizzard and r=alecf (assuming they are still valid)
as soon as the trunk opens for 0.9.2.

Comment 17

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Håkan - could you at least get module owner review on this again since it's been
so long, at least so they know you're doing this?  (Although it might be nice to
use timeless's patch if it doesn't change the control flow...)

Comment 18

[Håkan Waara]

I would prefer Kevin's patch since it's a simple fix whereas timeless' patch
fixes additional stuff.

Comment 19

[(not reading, please use [e-mail] instead)]

good call by dbaron to get a re-review.

naving is the right person to re-review this.

Comment 20

[Navin Gupta]

r=naving on Kevin Higgins patch. 

Comment 21

[Håkan Waara]

Fix checked in. Thanks Kevin for the fix!

Comment 22

[laurel]

Any reasonable way for me to verify this?

Comment 23

[laurel]

Marking verified (no response, assume no verification steps).