495711 - No Pause, Resume, Retry (etc) buttons in download manager on OS X

Status: RESOLVED FIXED

(SeaMonkey :: Download & File Handling, defect)

Description

[Stefan [:stefanh]]

Pause, Resume, Retry etc are all missing. This is because there is no downloadButtons.png in toolkit/themes/pinstripe/mozapps/downloads/.

Comment 1

[Stefan [:stefanh]]

(I'm talking about the icons, of course)

Comment 2

[Stefan [:stefanh]]

So, I think for classic we need a separate file - the pinstripe icons are much more "native"-looking. For modern, I guess we could use the winstripe icons - in other words, the icons need to be forked.

Comment 3

[Robert Kaiser]

Yes, I agree, we should use the look of the pinstripe icons on Mac, the unfortunate thing is that the image is different, so we need to do our own version(s) there in suite.

Comment 4

[Robert Kaiser]

Oh, Stefan, do we have a decision on where to place Mac-specific files in the future structure? we could make use of that here.

Comment 5

[Stefan [:stefanh]]

(In reply to comment #4)
> Oh, Stefan, do we have a decision on where to place Mac-specific files in the
> future structure? we could make use of that here.

Not really a decision, but I discussed this with Neil and there's basically 2 alternatives:
1) This structure: https://bug460699.bugzilla.mozilla.org/attachment.cgi?id=374593 (could be some errors there, but you get the general idea). It's the "lazy" version. I'm not 100% satisfied with it since it kind of makes the structure more complicated. It's not really logical either. But it's rather straight-forward to implement.

2)
suite/themes/classic/ <- windows, unix and cross-platform files, plus jar.mn
suite/themes/classic/mac/ <- mac-specific files, but in the master folder structure
suite/themes/classic/os2/communicator/toolbar.css <- os2-specific file

Even though Neil was OK with 1), he suggested 2) himself. I'd say that 2) makes more sense and it also has the potential for more forking in the future.

In this case, 2) would mean suite/themes/classic/mac/communicator/downloads/downloadmanager.css

Comment 6

[Robert Kaiser]

Attachment: use suite-specific icons with Mac-specific variant

OK, then let's try using mac/ - I don't need to make the CSS different but just the image, though. And as we are not using any hover images right now, we strip them from the images and just have the plain versions in the suite image.

Comment 7

[[e-mail]]

Is it me or are these buttons lacking alpha transparency?

Also, what are your plans for the Modern theme? No Mac ifdefs there!

Comment 8

[Robert Kaiser]

Attachment: Correct images, include Modern

OK, optipng apparently didn't like me much. Here's a patch with images that should include alpha, and I also included Modern in the patch.

Comment 9

[Robert Kaiser]

Pushed as http://hg.mozilla.org/comm-central/rev/1f43591cf720