495797 - fix invalid delete in mozilla/gfx/src/beos/nsRenderingContextBeOS.cpp

Status: RESOLVED INCOMPLETE

(Core :: General, defect)

Description

[Stanislav Brabec]

User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; cs-CZ; rv:1.9.1b4) Gecko/20090426 SUSE/3.5b4-2.1 Firefox/3.5b4
Build Identifier: Mozilla/5.0 (X11; U; Linux x86_64; cs-CZ; rv:1.9.1b4) Gecko/20090426 SUSE/3.5b4-2.1 Firefox/3.5b4

David Binderman found an apparent bug in the mozilla/gfx/src/beos/nsRenderingContextBeOS.cpp of Firefox 2:

just checked some of the source code in the Suse Linux factory package
kompozer-0.7.10-1.28 and I noticed the following

$ egrep "new|delete"
../BUILD/kompozer-0.7.10/mozilla/gfx/src/beos/nsRenderingContextBeOS.cpp |
fgrep utf8pos
                utf8pos = new PRInt32[aLength + 1];
                delete utf8pos;

Suggest use "delete []" not plain "delete".

Reference: https://bugzilla.novell.com/show_bug.cgi?id=444561

Reproducible: Always

Comment 1

[Matthias Versen [:Matti]]

/mozilla/gfx/src/beos/nsRenderingContextBeOS.cpp is no longer and the whole part is replaced by Thebes, it's part of the old Gecko1.8 branch.

As you can see here http://mxr.mozilla.org/mozilla-central/source/gfx/src/ the whole Beos directory is gone and I'm not sure if the Beos port is still maintained. 

BTW: Kompozer is independent from Mozilla.org

Comment 2

[Stanislav Brabec]

Attachment: invalid-delete-fix-beos.patch

Untested proposed patch based on firefox-2.0.0.21 source tree. Kompozer is independent from Mozilla.org, but bugs there often come from Mozilla.org.

Comment 3

[Nickolay_Ponomarev]

Judging from bonsai, Sergei should know if anyone cares about this..