Closed Bug 495871 Opened 16 years ago Closed 16 years ago

Memory leak in nsWindowsRestart.cpp

Categories

(Toolkit :: Startup and Profile System, defect)

Product:
Toolkit
Component:
Startup and Profile System
Platform:
ARM
Windows CE
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.9.2a1

People

(Reporter: hiro, Assigned: hiro)

Details

(Keywords: memory-leak)

Attachments

(1 file)

A patch
499 bytes, patch
dougt
: review+
Details | Diff | Splinter Review
Attached patch A patch — — Splinter Review
No description provided.
Attachment #380928 - Flags: review?(bugmail)
Comment on attachment 380928 [details] [diff] [review] A patch env is allocated via malloc in mozce_GetEnvironmentCL().
Attachment #380928 - Flags: review?(bugmail) → review+
Keywords: checkin-needed
Assignee: nobody → ikezoe
Status: NEW → ASSIGNED
Flags: blocking1.9.1?
Would take the patch if approval is requested and risk is explained, but not blocking 1.9.1 for it. Re-nom if you totally disagree.
Flags: blocking1.9.1? → blocking1.9.1-
Comment on attachment 380928 [details] [diff] [review] A patch I don't see any risk in freeing this local variable...
Attachment #380928 - Flags: approval1.9.1?
and it's in a #ifdef WINCE block
Ignore the weirdness in the commit message, please... http://hg.mozilla.org/mozilla-central/rev/d0c10e8bae37
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
Attachment #380928 - Flags: approval1.9.1? → approval1.9.1.1?
Attachment #380928 - Flags: approval1.9.1.1? → approval1.9.1.2?
Comment on attachment 380928 [details] [diff] [review] A patch This isn't needed for 1.9.1 since mobile is shipping off of 1.9.2. Please re-nom if that's incorrect.
Attachment #380928 - Flags: approval1.9.1.2?
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: