495959 - input inside xul <hbox align="center"/> is not displayed properly

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, defect)

Description

[arno renevier]

Attachment: testcase to reproduce the bug

Hi,

with a recent trunk, 

    <hbox flex="1" align="center">
        <html:input value="1"/>
          </hbox>

is not displayed correctly: text in html:input is too high.
For some reason, this does not happen for a document opened inside firefox, but a top window document in a xulrunner application (or inside a xul dialog).

Comment 1

[arno renevier]

Attachment: screenshot showing the bug

Comment 2

[Karl Tomlinson (:karlt)]

Hmm.  I couldn't reproduce in Minefield with a toplevel document using dom.disable_window_open_feature.location = false and

  netscape.security.PrivilegeManager.enablePrivilege("UniversalXPConnect");
  window.open("input.xul","_blank","chrome,location=no");

I wonder what might be different in xulrunner.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Karl, what happens if you run "firefox -chrome url:///to/input.xul"?

Comment 4

[Karl Tomlinson (:karlt)]

Can reproduce with -chrome, thanks!

Comment 5

[Karl Tomlinson (:karlt)]

Attachment: set NS_FRAME_CONTAINS_RELATIVE_HEIGHT for relative line-heights

The lines are not getting reflowed when the block height changes.
NS_FRAME_CONTAINS_RELATIVE_HEIGHT makes the reflow happen.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 383407 [details] [diff] [review]
set NS_FRAME_CONTAINS_RELATIVE_HEIGHT for relative line-heights

Look ok to me, but a slightly odd use of the flag (which is supposed to mean that the frame has _kids_ with heights that depends on its height, iirc)... David, can you check that over?

Comment 7

[Karl Tomlinson (:karlt)]

Attachment: reftest

Comment 8

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 383407 [details] [diff] [review]
set NS_FRAME_CONTAINS_RELATIVE_HEIGHT for relative line-heights

Seems ok to me.

Comment 9

[Karl Tomlinson (:karlt)]

http://hg.mozilla.org/mozilla-central/rev/b2e56e16c75d

Comment 10

[Karl Tomlinson (:karlt)]

reftest added:
http://hg.mozilla.org/mozilla-central/rev/144da47d8aad
http://hg.mozilla.org/mozilla-central/rev/794b04051344