4960 - Menu items should be disabled according to context

Status: VERIFIED FIXED

(Core :: XUL, defect, P3)

Description

[Claudius Gayle]

The componet here is a WAG.
This is not about menu items not working.

In general when you are presented with a browser window, there are many men items
tht don't apply. The edit menu is full of these e.g. cut, paste, undo, redo.
Through some sort of XP wizardry these men items are supposed to know whether are
not to be active.
All builds as of 19990411

Comment 1

[don]

Re-assigned to saari.

This bug is WAY too general.  Since Chris is implementing the menu enabling and
disabling code, it's off to him for now ...

Comment 2

[saari (gone)]

Um, Ok...

Are you asking that the menu title automatically grey out when all of it's items
are greyed out? I get the impression you're just expecting the enabled state to
be set, which will come in time as XPApps gets farther along.

Comment 3

[Claudius Gayle]

there are many manifestations (like Don says this is way general) but basically what I'm thinking is this: For example, when there
is nothing in the clipboard Edit|Paste is grey. When there is, it's active. When you're at your first page, Go|Back is grey, and Go|
Forward is grey when your at your most recent page. I notice they Back/Forward buttons are picking this up now, I just want the
menus to start to do so. That's all.

Comment 4

[saari (gone)]

Well, menuitems should be responding to this on Windows and GTK today. MacOS
won't get there until M9 I think.

Comment 5

[Claudius Gayle]

*** Bug 7927 has been marked as a duplicate of this bug. ***

Comment 6

[cpratt]

Changing summary slightly to make this easier for me to find in bug reports, and
assigning self as QA Contact. It's a general bug, given, but it's an important
one: menu items should be greyed out when unavailable (Cut and Copy when no text
is selected, Paste when the clipboard is empty, and so on).

Comment 7

[buster]

Chris, it's unclear from the conversation in this bug whether the mechanism to
dynamically disable menu items is working today or not.  In a meeting yesterday,
simon seemed to think this mechanism was not yet in place.  Could you please
comment?  Thanks.
Once the mechanism for dynamic enabling/disabling is in place, I suggest you
close this bug and QA write specific bugs on specific menu items (individually
or in very small groups of menu items, so developers can get a handle on each
individually.)

Comment 8

[cpratt]

Sounds like a plan. Just tell us when & we (QA) will start writing individual
bugs. Thanks!

Comment 9

[saari (gone)]

Ok, mac dynamic menus are in and I added the enable/disabled code, so all
platforms can enable/disable menu items now.

Comment 10

[Claudius Gayle]

based on prior comments now is the time to close this out and write new ones.
marking VERIFIED