496187 - New version of JEP (0.9.7.2), please land on branches

Status: VERIFIED FIXED

(Plugins Graveyard :: Java (Java Embedding Plugin), defect)

Description

[Steven Michaud [:smichaud] (Retired)]

JEP 0.9.7.2 fixes bug 495278 (a 1.9.0.12 blocker), and also handles
mouse events and timers more smoothly than previous versions of the
JEP.

I'd like to land JEP 0.9.7.2 on the 1.9.0 branch as soon as possible,
since it fixes a 1.9.0.12 blocker.

If possible, I'd like to land it on the 1.9.1 branch just after it
opens for post-RC changes.  Or maybe we should try to get it into the
RC.

http://javaplugin.sourceforge.net/

Those who want to try the new version right away will need to install
it "over" the older versions currently bundled with Mozilla.org
browsers.  I recommend installing the new JEP to your
/Library/Internet Plug-Ins/ folder, then removing older copy(ies) of
the JEP from your Mozilla.org browser(s).  For more information see
the JEP Readme (http://javaplugin.sourceforge.net/Readme.html).

Comment 1

[Steven Michaud [:smichaud] (Retired)]

Attachment: Change log for JEP 0.9.7.2

Comment 2

[Samuel Sidler (old account; do not CC)]

Is it worth taking this for 1.9.1 to fix bug 495278?

Comment 3

[Damon Sicore (:damons)]

Since bug 495278 isn't a blocker, I'd say it isn't worth taking this late.  But, I want to hear others chime in here.

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

I like the reporter's original request, which is to get this on the branch after we've stabilized for RC. That way we get nightly testing without jeopardizing our ship date.

Comment 5

[Daniel Veditz [:dveditz]]

Comment on attachment 381369 [details]
Change log for JEP 0.9.7.2

Approved for 1.9.0.12, a=dveditz for release-drivers

Comment 6

[Steven Michaud [:smichaud] (Retired)]

Landed on the 1.9.0 branch:

Checking in JavaEmbeddingPlugin.bundle/Contents/Info.plist;
/cvsroot/mozilla/plugin/oji/JEP/JavaEmbeddingPlugin.bundle/Contents/Info.plist,v  <--  Info.plist
new revision: 1.21; previous revision: 1.20
done
Checking in JavaEmbeddingPlugin.bundle/Contents/MacOS/JavaEmbeddingPlugin;
/cvsroot/mozilla/plugin/oji/JEP/JavaEmbeddingPlugin.bundle/Contents/MacOS/JavaEmbeddingPlugin,v  <--  JavaEmbeddingPlugin
new revision: 1.22; previous revision: 1.21
done
Checking in JavaEmbeddingPlugin.bundle/Contents/Resources/English.lproj/InfoPlist.strings;
/cvsroot/mozilla/plugin/oji/JEP/JavaEmbeddingPlugin.bundle/Contents/Resources/English.lproj/InfoPlist.strings,v  <--  InfoPlist.strings
new revision: 1.21; previous revision: 1.20
done
Checking in JavaEmbeddingPlugin.bundle/Contents/Resources/Java/JavaEmbeddingPlugin.jar;
/cvsroot/mozilla/plugin/oji/JEP/JavaEmbeddingPlugin.bundle/Contents/Resources/Java/JavaEmbeddingPlugin.jar,v  <--  JavaEmbeddingPlugin.jar
new revision: 1.21; previous revision: 1.20
done
Checking in MRJPlugin.plugin/Contents/Info.plist;
/cvsroot/mozilla/plugin/oji/JEP/MRJPlugin.plugin/Contents/Info.plist,v  <--  Info.plist
new revision: 1.21; previous revision: 1.20
done
Checking in MRJPlugin.plugin/Contents/MacOS/MRJPlugin;
/cvsroot/mozilla/plugin/oji/JEP/MRJPlugin.plugin/Contents/MacOS/MRJPlugin,v  <--  MRJPlugin
new revision: 1.22; previous revision: 1.21
done
Checking in MRJPlugin.plugin/Contents/MacOS/MRJPlugin.jar;
/cvsroot/mozilla/plugin/oji/JEP/MRJPlugin.plugin/Contents/MacOS/MRJPlugin.jar,v  <--  MRJPlugin.jar
new revision: 1.21; previous revision: 1.20
done
Checking in MRJPlugin.plugin/Contents/Resources/MRJPlugin.rsrc;
/cvsroot/mozilla/plugin/oji/JEP/MRJPlugin.plugin/Contents/Resources/MRJPlugin.rsrc,v  <--  MRJPlugin.rsrc
new revision: 1.17; previous revision: 1.16
done
Checking in MRJPlugin.plugin/Contents/Resources/English.lproj/InfoPlist.strings;
/cvsroot/mozilla/plugin/oji/JEP/MRJPlugin.plugin/Contents/Resources/English.lproj/InfoPlist.strings,v  <--  InfoPlist.strings
new revision: 1.21; previous revision: 1.20
done

Comment 7

[Samuel Sidler (old account; do not CC)]

This still needs to land on 1.9.1, so it can't be called FIXED yet.

Comment 8

[Steven Michaud [:smichaud] (Retired)]

Comment on attachment 381369 [details]
Change log for JEP 0.9.7.2

For when the 1.9.1-branch reopens.

Comment 9

[Samuel Sidler (old account; do not CC)]

Fixed this in 1.9.0.12, so we should fix it in 1.9.1.1.

Comment 10

[Samuel Sidler (old account; do not CC)]

Comment on attachment 381369 [details]
Change log for JEP 0.9.7.2

Approved for 1.9.1.1. a=ss for release-drivers.

Comment 11

[Steven Michaud [:smichaud] (Retired)]

Landed on the 1.9.1 branch:
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/545af0c70e7e

I guess this should now be marked FIXED :-)

Comment 12

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Steven the build Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1.1pre) Gecko/20090715 Shiretoko/3.5.1pre ID:20090715031842 still lists Java Embedding Plugin 0.9.7.1 for me. Why don't I see the new version?

Comment 13

[Steven Michaud [:smichaud] (Retired)]

I'll bet you're looking at the about:plugins page.  It sometimes shows
more than one version.  Scroll down and you should also see JEP
0.9.7.2.

I just downloaded today's Shiretoko nightly and have confirmed that it
bundles JEP 0.9.7.2 -- I right-clicked on MRJPlugin.plugin and
JavaEmbeddingPlugin.bundle in the distro's Contents/MacOS/plugins
directory, chose Get Info, and checked the version numbers.  You can
see that this is what gets loaded by running Shiretoko in gdb and
entering 'info sharedlibrary'.

I've never figured out exactly what triggers multiple JEP versions in
the about:plugins page.  If it's just that the "old" entry didn't get
expunged, you can "fix" the problem by deleting/renaming pluginreg.dat
and re-running the browser.  But if you have copies of the JEP both in
the distro and in /Library/Internet Plug-Ins/, the browser will
legitimately find two copies of the JEP -- perhaps with different
versions.  The browser will always load the right one (the one in its
Contents/MacOS/plugins directory), though.

It's also possible your pluginreg.dat will legitimately contain
multiple versions of the JEP if you run multiple copies of FF with the
same profile, and those copies of FF bundle multiple versions of the
JEP.

Comment 14

[Henrik Skupin [:whimboo][⌚️UTC+2]]

No I don't have it listed in about:plugins and the plug-ins tab of the add-ons manager! When I use Finder to check the version via the file info window it shows me 0.9.7.2. But why the old version is still shown in Firefox? Do we miss something on the AUS side?

Comment 15

[Henrik Skupin [:whimboo][⌚️UTC+2]]

FYI, it works as expected for a fresh profile but an older one still uses the old plug-in.

Comment 16

[Steven Michaud [:smichaud] (Retired)]

> but an older one still uses the old plug-in

This shouldn't be possible.  Did you check in gdb using 'info sharedlibrary'?

Comment 17

[Steven Michaud [:smichaud] (Retired)]

From talking to Henrik on IRC, it seems his copy of Shiretoko (today's nightly) is loading JEP 0.9.7.2, but the information in pluginreg.dat (what gets displayed in about:plugins and the plug-ins tab) hasn't gotten updated from JEP 0.9.7.1.

I have some ideas why, but am waiting for more information.

Henrik or I will say more later.

Comment 18

[Marcia Knous [:marcia]]

I am seeing the same thing as Henrik sees in Comment 17 on all my various mac machines.

Comment 19

[Henrik Skupin [:whimboo][⌚️UTC+2]]

See bug 504397 for an ongoing discussion about that updating issue.

Comment 20

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Verified fixed with a fresh profile and Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1.1pre) Gecko/20090715 Shiretoko/3.5.1pre ID:20090715031842

Comment 21

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Trunk is not affected. Only 1.9.1 and 1.9.0.