496277 - unit test for bug 496103 (browser_drag_bookmarks_on_toolbar.js) fails on Linux

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[:Gavin Sharp [email: [e-mail]]]

Not sure why, see:
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1244095054.1244099427.29941.gz&fulltext=1

I had to disable it:
https://hg.mozilla.org/mozilla-central/rev/9d6f5ab54933

Comment 1

[Marco Bonardo [:mak]]

just for curiosity, any reason you have not used navigator.platform?

Comment 2

[:Gavin Sharp [email: [e-mail]]]

I went with something tried&tested, it was 3:30AM :)

http://mxr.mozilla.org/mozilla-central/source/browser/components/shell/test/browser_420786.js#83

Comment 3

[Marco Bonardo [:mak]]

i asked because maybe there was a reason to not use navigator.platform, since i usually use that. I learn something new every day :)

About linux, it has strange interactions between menus and drag&drop, i had to workaround those in toolbar.xml, so that actually i have to detect a drag and prevent popupshowing event. I have not yet tried if the D&D regression is fixed on linux, but i've spent some time fixing my env, so now i can run all supported OS at the same time, will check soon if we can support the test in Linux.

Comment 4

[Marco Bonardo [:mak]]

the problem on linux is the drag threshold, looks like we need to move 8 pixels before a drag starts, so setting the increment to 9 instead of 8 makes the test pass.

Comment 5

[Marco Bonardo [:mak]]

Attachment: patch v1.0

Comment 6

[Marco Bonardo [:mak]]

Comment on attachment 381656 [details] [diff] [review]
patch v1.0

trybuilds did not show any error in Places browser chrome test, so this should be fine.

Comment 7

[Marco Bonardo [:mak]]

http://hg.mozilla.org/mozilla-central/rev/98006ec7bd98