Closed Bug 496308 Opened 15 years ago Closed 15 years ago

Crash [@ nsDOMPopupBlockedEvent::GetRequestingWindow]

Categories

(Core :: DOM: Events, defect)

Product:
Core
Component:
DOM: Events
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
critical

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
blocking1.9.1 --- .2+
status1.9.1 --- .2-fixed

People

(Reporter: smaug, Assigned: smaug)

References

(
URL
)

Details

(4 keywords)

Crash Data

Attachments

(2 files)

null check
950 bytes, patch
sicking
: review+
sicking
: superreview+
Details | Diff | Splinter Review
with crashtest
1.49 KB, patch
beltzner
: approval1.9.1.1-
samuel.sidler+old
: approval1.9.1.2+
dveditz
: approval1.9.0.12+
Details | Diff | Splinter Review
Attached patch null check — — Splinter Review 
      No description provided.
Attachment #381506 - Flags: superreview?(jonas)
Attachment #381506 - Flags: review?(jonas)
Comment on attachment 381506 [details] [diff] [review]
null check

r/sr=me if you add a crashtest :)
Attachment #381506 - Flags: superreview?(jonas)
Attachment #381506 - Flags: superreview+
Attachment #381506 - Flags: review?(jonas)
Attachment #381506 - Flags: review+
Blocks: 496317
http://hg.mozilla.org/mozilla-central/rev/a785e143ec10
Status: NEW → RESOLVED
Closed: 15 years ago
Flags: wanted1.9.1?
Resolution: --- → FIXED
Comment on attachment 381512 [details] [diff] [review]
with crashtest

Maybe too late for .12
Attachment #381512 - Flags: approval1.9.0.12?
Assignee: nobody → Olli.Pettay
Flags: wanted1.9.1?
Flags: wanted1.9.1.x?
Flags: wanted1.9.0.x?
Severity: normal → critical
Keywords: crash
Comment on attachment 381512 [details] [diff] [review]
with crashtest

Approved for 1.9.0.12, a=dveditz for release-drivers
Attachment #381512 - Flags: approval1.9.0.12? → approval1.9.0.12+
Flags: wanted1.9.1.x?
Flags: wanted1.9.1.x+
Flags: wanted1.9.0.x?
Flags: wanted1.9.0.x+
Flags: blocking1.9.0.12+
Keywords: testcase
Keywords: fixed1.9.0.12
Fixed this in 1.9.0.12, so we should fix it in 1.9.1.x, maybe 1.9.1.1?
Flags: blocking1.9.1.1?
Olli, does this patch apply to 1.9.1? Let's fix it there.
Flags: blocking1.9.1.1? → blocking1.9.1.1+
Attachment #381512 - Flags: approval1.9.1.1?
blocking1.9.1: --- → .2+
Flags: blocking1.9.1.1+ → blocking1.9.1.1-
Comment on attachment 381512 [details] [diff] [review]
with crashtest

In fact, let's fix it on 1.9.1.2 :)
Attachment #381512 - Flags: approval1.9.1.2?
Attachment #381512 - Flags: approval1.9.1.1?
Attachment #381512 - Flags: approval1.9.1.1-
Comment on attachment 381512 [details] [diff] [review]
with crashtest

Approved for 1.9.1.2. a=ss for release-drivers
Attachment #381512 - Flags: approval1.9.1.2? → approval1.9.1.2+
Verified with testcase in URL field. 3.0.10/3.5 crash on load. 3.0.12/3.5.2 do not:

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1.2) Gecko/20090729 Firefox/3.5.2
Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.0.12) Gecko/2009070609 Firefox/3.0.12
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.0.12) Gecko/2009070611 Firefox/3.0.12 (.NET CLR 3.5.30729)
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.2) Gecko/20090729 Firefox/3.5.2 (.NET CLR 3.5.30729)
Keywords: fixed1.9.0.12 → verified1.9.0.12, verified1.9.1
Crash Signature: [@ nsDOMPopupBlockedEvent::GetRequestingWindow]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: