496337 - ###!!! ASSERTION: bad action nesting!: 'mActionNesting>0'

Status: ASSIGNED

(Core :: DOM: Editor, defect)

Description

[Peter Van der Beken [:peterv]]

This assertion show up when BeforeEdit fails somewhere and as a result it doesn't increment mActionNesting. AfterEdit always checks mActionNesting and decrements before trying anything else. I'm not really sure why we have mActionNesting, since BeforeEdit/AfterEdit are only called by StartOperation/EndOperation, which are called by nsAutoRules which checks that StartOperation/EndOperation are only called once even for nested actions. I think we should make mActionNesting DEBUG-only and increment/decrement at the top of BeforeEdit/AfterEdit.

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

(In reply to comment #0)
> This assertion show up when BeforeEdit fails somewhere and as a result it
> doesn't increment mActionNesting.

There's a much-neglected work-in-progress patch, in bug 336091, which corrects mActionNesting increment/decrement.

> I think we should make mActionNesting DEBUG-only and increment/decrement
> at the top of BeforeEdit/AfterEdit.

Sounds reasonable.