Open Bug 496337 Opened 15 years ago Updated 2 years ago

###!!! ASSERTION: bad action nesting!: 'mActionNesting>0'

Categories

(Core :: DOM: Editor, defect)

defect

Tracking

()

ASSIGNED

People

(Reporter: peterv, Assigned: peterv)

References

Details

This assertion show up when BeforeEdit fails somewhere and as a result it doesn't increment mActionNesting. AfterEdit always checks mActionNesting and decrements before trying anything else. I'm not really sure why we have mActionNesting, since BeforeEdit/AfterEdit are only called by StartOperation/EndOperation, which are called by nsAutoRules which checks that StartOperation/EndOperation are only called once even for nested actions. I think we should make mActionNesting DEBUG-only and increment/decrement at the top of BeforeEdit/AfterEdit.
(In reply to comment #0)
> This assertion show up when BeforeEdit fails somewhere and as a result it
> doesn't increment mActionNesting.

There's a much-neglected work-in-progress patch, in bug 336091, which corrects mActionNesting increment/decrement.

> I think we should make mActionNesting DEBUG-only and increment/decrement
> at the top of BeforeEdit/AfterEdit.

Sounds reasonable.
Blocks: 336091
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.