Closed Bug 496422 Opened 15 years ago Closed 15 years ago

delete of an enclosing function's argument deletes the wrong variable

Categories

(Core :: JavaScript Engine, defect, P2)

Product:
Core
Component:
JavaScript Engine
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.9.1

People

(Reporter: mrbkap, Assigned: brendan)

References

Details

(Keywords: fixed1.9.1, Whiteboard: fixed-in-tracemonkey)

Attachments

(2 files, 1 obsolete file)

fix, v2
3.39 KB, patch
igor
: review+
mrbkap
: review+
Details | Diff | Splinter Review
js shell testcase
390 bytes, text/plain
Details 
Split out from bug 496245:
js> a = 10
10
js> (function(a){ (function(){delete a;})(); })();
js> a
typein:3: ReferenceError: a is not defined
js>
Regression from ES1-3 semantics, could be more trouble than taking the patch (which is about to be attached).

/be
Assignee: general → brendan
Blocks: upvar2
Status: NEW → ASSIGNED
Flags: wanted1.9.1?
OS: Linux → All
Priority: -- → P2
Hardware: x86 → All
Target Milestone: --- → mozilla1.9.1
Attachment #382048 - Flags: review?(mrbkap)
Attached patch fix, v2 — — Splinter Review 

        Attachment #382048 -
        Attachment is obsolete: true

        Attachment #382051 -
        Flags: review?(igor)

        Attachment #382048 -
        Flags: review?(mrbkap)

        Attachment #382048 -
        Flags: review?(igor)

    
  

        Attachment #382051 -
        Flags: review?(mrbkap)

    
    

    
  

      
      
      
      

        Attached file
          
        js shell testcase
        — 
      

    


  
The output should be

false
true
true
false
false

but the last false is true, in Firefox 3 or with this patch. Pre-existing bug in indirect eval, a WONTFIX because we will make indirect eval be global eval very soon for 1.9.2.

/be

    
  
Flags: in-testsuite?

    
  

        Attachment #382051 -
        Flags: review?(igor) → review+

    
    

    
  
http://hg.mozilla.org/tracemonkey/rev/1f99f42b5382

/be
Whiteboard: fixed-in-tracemonkey

    
    

    
  
http://hg.mozilla.org/mozilla-central/rev/1f99f42b5382
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED

    
  
Flags: wanted1.9.1? → wanted1.9.1+

    
  

        Attachment #382051 -
        Flags: review?(mrbkap) → review+

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: