Closed
Bug 496510
Opened 15 years ago
Closed 14 years ago
Buildbot sendchanges should include revision where appropriate
Categories
(Release Engineering :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: catlee, Assigned: lsblakk)
References
Details
Attachments
(1 file, 1 obsolete file)
675 bytes,
patch
|
catlee
:
review+
|
Details | Diff | Splinter Review |
When doing a sendchange to notify buildbot masters of a new build to test for Talos or unittests, it would be useful to include the revision of the build in the SendChangeStep. This will make it easier to correlate all these different builds on different masters back to the original revision, which makes certain types of data analysis easier.
Assignee | ||
Updated•15 years ago
|
Component: Release Engineering → Release Engineering: Future
Assignee | ||
Updated•15 years ago
|
Component: Release Engineering: Future → Release Engineering
Assignee | ||
Updated•15 years ago
|
Assignee: nobody → lsblakk
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•15 years ago
|
||
This one needs to go on top of the patch for bug 496509
Attachment #381836 -
Flags: review?(catlee)
Reporter | ||
Comment 2•15 years ago
|
||
Comment on attachment 381836 [details] [diff] [review] add revision to talos and unittest sendchanges >diff --git a/process/factory.py b/process/factory.py >--- a/process/factory.py >+++ b/process/factory.py >@@ -878,6 +878,7 @@ > warnOnFailure=warn, > master=master, > branch=talosBranch, >+ revision=WithProperties("%got_revision)s"), Missing a '(' here, and below. > files=[WithProperties('%(packageUrl)s')], > user="sendchange") > ) >@@ -887,6 +888,7 @@ > warnOnFailure=warn, > master=master, > branch=unittestBranch, >+ revision=WithProperties("%got_revision)s"), > files=[WithProperties('%(packageUrl)s')], > user="sendchange-unittest") > )
Attachment #381836 -
Flags: review?(catlee) → review-
Assignee | ||
Comment 3•15 years ago
|
||
Sorry bout that. Parentheses added.
Attachment #381836 -
Attachment is obsolete: true
Attachment #381840 -
Flags: review?(catlee)
Reporter | ||
Updated•15 years ago
|
Attachment #381840 -
Flags: review?(catlee) → review+
Assignee | ||
Updated•15 years ago
|
Attachment #381840 -
Flags: checked‑in?
Assignee | ||
Comment 4•15 years ago
|
||
catlee tested this on staging and it's good to go for next downtime.
Reporter | ||
Comment 5•15 years ago
|
||
Comment on attachment 381840 [details] [diff] [review] add revision to talos and unittest sendchanges changeset: 333:e71164e1b848
Reporter | ||
Updated•15 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•14 years ago
|
Attachment #381840 -
Flags: checked-in?
Reporter | ||
Comment 6•14 years ago
|
||
Looks like we're missing this for the UnittestBuildFactory. Could happen as a ride-along to 520227
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 7•14 years ago
|
||
it went in with bug 520227: http://hg.mozilla.org/build/buildbotcustom/file/1fa53b45a8f5/process/factory.py#l3693
Status: REOPENED → RESOLVED
Closed: 15 years ago → 14 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
Product: mozilla.org → Release Engineering
You need to log in
before you can comment on or make changes to this bug.
Description
•