Buildbot sendchanges should include revision where appropriate

RESOLVED FIXED

Status

Release Engineering
General
RESOLVED FIXED
9 years ago
5 years ago

People

(Reporter: catlee, Assigned: lsblakk)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

9 years ago
When doing a sendchange to notify buildbot masters of a new build to test for Talos or unittests, it would be useful to include the revision of the build in the SendChangeStep.

This will make it easier to correlate all these different builds on different masters back to the original revision, which makes certain types of data analysis easier.
(Assignee)

Updated

9 years ago
Component: Release Engineering → Release Engineering: Future
(Assignee)

Updated

9 years ago
Component: Release Engineering: Future → Release Engineering
(Assignee)

Updated

9 years ago
Assignee: nobody → lsblakk
Status: NEW → ASSIGNED
(Assignee)

Comment 1

9 years ago
Created attachment 381836 [details] [diff] [review]
add revision to talos and unittest sendchanges

This one needs to go on top of the patch for bug 496509
Attachment #381836 - Flags: review?(catlee)
(Reporter)

Comment 2

9 years ago
Comment on attachment 381836 [details] [diff] [review]
add revision to talos and unittest sendchanges

>diff --git a/process/factory.py b/process/factory.py
>--- a/process/factory.py
>+++ b/process/factory.py
>@@ -878,6 +878,7 @@
>              warnOnFailure=warn,
>              master=master,
>              branch=talosBranch,
>+             revision=WithProperties("%got_revision)s"),

Missing a '(' here, and below.

>              files=[WithProperties('%(packageUrl)s')],
>              user="sendchange")
>             )
>@@ -887,6 +888,7 @@
>              warnOnFailure=warn,
>              master=master,
>              branch=unittestBranch,
>+             revision=WithProperties("%got_revision)s"),
>              files=[WithProperties('%(packageUrl)s')],
>              user="sendchange-unittest")
>             )
Attachment #381836 - Flags: review?(catlee) → review-
(Assignee)

Comment 3

9 years ago
Created attachment 381840 [details] [diff] [review]
add revision to talos and unittest sendchanges

Sorry bout that.  Parentheses added.
Attachment #381836 - Attachment is obsolete: true
Attachment #381840 - Flags: review?(catlee)
(Reporter)

Updated

9 years ago
Attachment #381840 - Flags: review?(catlee) → review+
(Assignee)

Updated

9 years ago
Attachment #381840 - Flags: checked‑in?
(Assignee)

Comment 4

9 years ago
catlee tested this on staging and it's good to go for next downtime.
(Reporter)

Comment 5

9 years ago
Comment on attachment 381840 [details] [diff] [review]
add revision to talos and unittest sendchanges

changeset:   333:e71164e1b848
(Reporter)

Updated

9 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
(Assignee)

Updated

8 years ago
Attachment #381840 - Flags: checked-in?
(Reporter)

Comment 6

8 years ago
Looks like we're missing this for the UnittestBuildFactory.  Could happen as a ride-along to 520227
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Reporter)

Updated

8 years ago
Blocks: 550176
(Assignee)

Comment 7

8 years ago
it went in with bug 520227:

http://hg.mozilla.org/build/buildbotcustom/file/1fa53b45a8f5/process/factory.py#l3693
Status: REOPENED → RESOLVED
Last Resolved: 9 years ago8 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.