Closed Bug 496510 Opened 15 years ago Closed 14 years ago

Buildbot sendchanges should include revision where appropriate

Categories

(Release Engineering :: General, defect)

x86
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: catlee, Assigned: lsblakk)

References

Details

Attachments

(1 file, 1 obsolete file)

When doing a sendchange to notify buildbot masters of a new build to test for Talos or unittests, it would be useful to include the revision of the build in the SendChangeStep.

This will make it easier to correlate all these different builds on different masters back to the original revision, which makes certain types of data analysis easier.
Component: Release Engineering → Release Engineering: Future
Component: Release Engineering: Future → Release Engineering
Assignee: nobody → lsblakk
Status: NEW → ASSIGNED
This one needs to go on top of the patch for bug 496509
Attachment #381836 - Flags: review?(catlee)
Comment on attachment 381836 [details] [diff] [review]
add revision to talos and unittest sendchanges

>diff --git a/process/factory.py b/process/factory.py
>--- a/process/factory.py
>+++ b/process/factory.py
>@@ -878,6 +878,7 @@
>              warnOnFailure=warn,
>              master=master,
>              branch=talosBranch,
>+             revision=WithProperties("%got_revision)s"),

Missing a '(' here, and below.

>              files=[WithProperties('%(packageUrl)s')],
>              user="sendchange")
>             )
>@@ -887,6 +888,7 @@
>              warnOnFailure=warn,
>              master=master,
>              branch=unittestBranch,
>+             revision=WithProperties("%got_revision)s"),
>              files=[WithProperties('%(packageUrl)s')],
>              user="sendchange-unittest")
>             )
Attachment #381836 - Flags: review?(catlee) → review-
Sorry bout that.  Parentheses added.
Attachment #381836 - Attachment is obsolete: true
Attachment #381840 - Flags: review?(catlee)
Attachment #381840 - Flags: review?(catlee) → review+
Attachment #381840 - Flags: checked‑in?
catlee tested this on staging and it's good to go for next downtime.
Comment on attachment 381840 [details] [diff] [review]
add revision to talos and unittest sendchanges

changeset:   333:e71164e1b848
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Attachment #381840 - Flags: checked-in?
Looks like we're missing this for the UnittestBuildFactory.  Could happen as a ride-along to 520227
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Blocks: 550176
it went in with bug 520227:

http://hg.mozilla.org/build/buildbotcustom/file/1fa53b45a8f5/process/factory.py#l3693
Status: REOPENED → RESOLVED
Closed: 15 years ago14 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: