Closed Bug 496529 Opened 11 years ago Closed 11 years ago

Bug 488951 causes disable SSE2 code of YUV->RGB conversion on Windows

Categories

(Core :: Audio/Video, defect)

x86
Windows XP
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: m_kato, Assigned: kinetik)

References

()

Details

Attachments

(1 file)

The following code will turn off SSE2 code of liboggplay on Windows.

changeset:   25640:02d3b944151b
user:        Matthew Gregan <kinetik@flim.org>
date:        Wed May 20 14:46:58 2009 +1200
summary:     bug 488951. Fix YUV conversion to deal with odd-size video frames. rs=roc

Because ATTRIBUTE_ALIGNED_MAX isn't defined on config_win32.h, it only uses SSE and MMX code on Windows.  (Linux and Mac is no problem.)  Also, I filed a bug to liboggplay's Trac (https://trac.annodex.net/ticket/480).  A patch is attached on this Trac.
Thanks for finding this.  I noticed this and fixed it as part of bug 485291, but the local patch containing the fix was removed later when we updated the YUV code to upstream to pick up other fixes for bug 488951.  I sent the fix upstream, but since the patch was never applied in the form I sent, this particular fix went missing.

In practice, I don't think there's much difference in speed between the SSE/MMX code and the SSE2 code in its current form, but we should fix this anyway.
Attached patch patch v0Splinter Review
Fix with a local patch.  When we next sync with upstream, this patch will fail to apply with conflicts and remind whoever is updating to check that a similar fix has been made upstream.
Assignee: nobody → kinetik
Status: NEW → ASSIGNED
Attachment #381737 - Flags: superreview?(roc)
Attachment #381737 - Flags: review?(roc)
Attachment #381737 - Flags: superreview?(roc)
Attachment #381737 - Flags: superreview+
Attachment #381737 - Flags: review?(roc)
Attachment #381737 - Flags: review+
pushed to mozilla-central:
http://hg.mozilla.org/mozilla-central/rev/517488f53cb8
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.