496664 - unusual behavior (XUL caching ? chrome.manifest ?) of Stylish in Addons Manager on Mac OS X

Status: RESOLVED WORKSFORME

(Toolkit :: Add-ons Manager, defect)

Description

[mcdavis941 (sporadically reading bugmail)]

Problem: Stylish (add-on) makes UI changes to the Add-ons Manager which get different results based on whether XUL caching is enabled or not.  This seems strange.  (OS X only.)

Background: Stylish (versions 1.x and up) adds a new view and viewbutton to the Add-ons Manager.  On Windows, the viewbutton shows an icon, like all the other viewbuttons.  On OS X, Stylish hides the viewbutton icon (because on OS X none of the other viewbuttons have icons either).  It does this with a CSS rule setting display:none.  This is in a CSS file which is only loaded when on OS X, using a chrome.manifest "os" directive.

This CSS rule only matches sometimes, so that sometimes you see the Stylish icon (which you shouldn't) and sometimes you don't.  You can make it appear or disappear by changing an about:config setting for XUL caching or by enabling or disabling any other extension and restarting.  See screenshots and STR below.

http://i54.photobucket.com/albums/g112/mcdavis941/stylishemiconvisible.png
http://i54.photobucket.com/albums/g112/mcdavis941/stylishemiconhidden.png

STR: 

1. Install Stylish 1.0.2 on Fx3.5b4 on OS X.
2. Restart Firefox twice.
3. Open the Addons Manager, notice the icon, which should not be there.
4. Disable or enable any extension (other than Stylish).
5. Restart Firefox.
6. Open the Addons Manager, notice the icon is gone, as it should be.
7. Close the Addons Manager and restart Firefox.
8. Open the Addons Manager.  Notice the icon is back.
9. In summary: you can make the icon go away by disabling or enabling any extension (marking the XUL cache dirty?) and then restarting Firefox.  Restarting Firefox without first enabling or disabling some extension brings the icon back (showing the error).

STR with nglayout.debug.disable_xul_cache:

10. Disable XUL caching in about:config. nglayout.debug.disable_xul_cache=true
11. Restart Firefox.  Notice the icon is hidden.
12. Repeat all of the above STR 1-9, notice the icon is never there.
13. Reenable XUL caching (nglayout.debug.disable_xul_cache=false), restart twice and you again see the error.

DOM Inspector shows the CSS rule setting display:none (from chrome://stylish/skin/manage-addons-mac.css) is present on the viewbutton when the icon is hidden and gone when the icon is shown.

Happens with:
- Fx3.5b4
- OS X 10.5.7
- Stylish 1.0.2
- default theme

Works as expected (never shows icon) with Fx3.x.

Comment 1

[mcdavis941 (sporadically reading bugmail)]

About the CSS rule, s/display/list-style-image/

Comment 2

[Rotis]

Attachment: The same bug in Thunderbird 3.0

The same bug occurs in Thunderbird 3.0 and OSX Snow Leopard!

Happens with:

- Thunderbird 3.0 Final
- Mac OS X 10.6.2
- Stylish 1.0.7
- default theme

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

WFM with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.2.6) Gecko/20100625 Firefox/3.6.6 ID:20100625223402

Please test if you are still able to see this problem. For me the issue described in comment 0 is fixed.