496670 - Bugzilla needs better patch review process with annotations and versioned patches

Status: REOPENED

(Bugzilla :: Attachments & Requests, enhancement)

Description

[David D. Kilzer (ddk)]

* SUMMARY
It would be nice if Bugzilla had an integrated, enhanced review process that allowed patches to be annotated and "versioned", similar to tools like Reitveld <http://code.google.com/p/rietveld/> or Review Board <http://www.review-board.org/>.

Comment 1

[Frédéric Buclin]

Looks like a dupe of bug 291328 to me. I'm not sure I want "duplicated" code to do something which can already be done by a 3rd party tool.

Comment 2

[David D. Kilzer (ddk)]

(In reply to comment #1)
> Looks like a dupe of bug 291328 to me.

It's certainly related, but I wouldn't consider it a dupe.  This is more about making the patch review process support more features, specifically:

- Annotating patches (adding comments about certain parts of a patch that are displayed on demand) instead of the more simple "Edit as comment" button, which makes large patches difficult to review since so much editing is involved.

- Versioning the same patch so that instead of having N obsolete patches with 1 reviewed patch, Bugzilla would present a single patch attachment with multiple versions of it available, and be able to show differences between the patches themselves ("diff" the patches, if you will).

There may be other features, but those were the main two.  (I probably should have split this into two bugs, huh?)

Comment 3

[Frédéric Buclin]

(In reply to comment #2)
> - Versioning the same patch so that instead of having N obsolete patches with 1
> reviewed patch, Bugzilla would present a single patch attachment with multiple
> versions of it available, and be able to show differences between the patches
> themselves ("diff" the patches, if you will).

There is the interdiff feature which does that, already. I don't think we need any improvement in this area.

Comment 4

[(not currently active) Ted Mielczarek]

Is this obsoleted by Splinter?

Comment 5

[David Lawrence [:dkl]]

Yes this is mostly a duplicate of the Splinter effort. There are a couple of features mentioned in comment 0 and comment 2 that are not yet in Splinter that we would still need to implement. Primarily versioning of patches. Interdiff does do this to some extent but they are separate tools as far as Bugzilla is concerned. There could be some work to integrate the two in the future.

You can do annotations with the current version of Splinter. We should close this bug and open up separate very specific bug reports against the Splinter component that addresses each of the requested features.

dkl

Comment 6

[Frédéric Buclin]

bmo is not Bugzilla, and vanilla Bugzilla has no such feature yet. Reopening!

Comment 7

[David Lawrence [:dkl]]

(In reply to comment #6)
> bmo is not Bugzilla, and vanilla Bugzilla has no such feature yet. Reopening!

Apologize that I misread the product and closed this. I just saw the mention of Splinter and made the wrong assumption.

dkl