496757 - Support encoding the OS build into symbol manifest filename and symbol output dirname

Status: RESOLVED FIXED

(Camino Graveyard :: General, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: Encode build into manifest filenames and symbol output dirnames

As we've learned from the 10.4.11 situation, we can end up legitimately having different builds with the same version number, e.g. 8S165 is 10.4.11 PPC without Security Update (2009-002), whereas 8S167 is 10.4.11 PPC with that update (and, apparently, 8S2167 is the Universal/Intel build).

I'm not positive that we'll experience this situation with current OSes, but certainly once they hit security-only status I expect we'll see 10.5.x with increasing build numbers.  It's probably overkill for current OSes, but it should still help us keep better track of things.

To allow us to be able to match the build between the manifest and the crash reports (and, implicitly, upload for each security update without clobbering the manifest), it'd be useful to encode the OS build into the manifest.

Attached is a patch based on the manual changes I made to the manifest filename when uploading the 8S165 symbols from cb-minibinus; I've tested it locally (which is why there's a chomp.gsub for os_build, because otherwise we happily create file and folder names with newlines in them!).  I also changed the symbol_output_dir to use the build so as not to clobber (and confuse) any existing symbol_output_dirs that are around.

Comment 1

[Stuart Morgan]

Comment on attachment 381980 [details] [diff] [review]
Encode build into manifest filenames and symbol output dirnames

>+os_build = `sw_vers -buildVersion`.chomp.gsub('\n', '')

Removing a trailing newline is what chomp does, so the gsub should be removed.

sr=smorgan with that change.

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to comment #1)
> (From update of attachment 381980 [details] [diff] [review])
> >+os_build = `sw_vers -buildVersion`.chomp.gsub('\n', '')
> 
> Removing a trailing newline is what chomp does, so the gsub should be removed.

The perils of coding by copy-paste in a language one doesn't know! ;)  Fixed.