Closed
Bug 496840
Opened 16 years ago
Closed 16 years ago
Dynamic changes to fieldset legends don't work
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
People
(Reporter: roc, Assigned: roc)
References
Details
Attachments
(1 file)
|
7.66 KB,
patch
|
bzbarsky
:
review+
bzbarsky
:
superreview+
|
Details | Diff | Splinter Review |
See upcoming patch and tests. nsFieldsetFrame::AppendFrames/InsertFrames/RemoveFrame fail when multiple legends are present. They also fail to handle cases induced by my patch in bug 495385, where ContentInserted on a <legend> frame may create a frame for a text node that precedes it, so we InsertFrames with a text frame followed by the legend.
|
Assignee | |
Comment 1•16 years ago
|
||
Easy stuff really...
Attachment #382068 -
Flags: superreview?(bzbarsky)
Attachment #382068 -
Flags: review?(bzbarsky)
|
||
Comment 2•16 years ago
|
||
Comment on attachment 382068 [details] [diff] [review]
fix
So the key here is that we never take the ContentAppended codepath for fieldset content because of the multiple insertion points thing? I guess that works, sure.
Attachment #382068 -
Flags: superreview?(bzbarsky)
Attachment #382068 -
Flags: superreview+
Attachment #382068 -
Flags: review?(bzbarsky)
Attachment #382068 -
Flags: review+
|
|
Assignee | |
Comment 3•16 years ago
|
||
Yes.
|
||
Comment 4•16 years ago
|
||
+ // aFrameList is not allowed to contain "the legend" for this frameset
s/frameset/fieldset/ in two places
|
|
Assignee | |
Comment 5•16 years ago
|
||
Thanks
|
|
Assignee | |
Comment 6•16 years ago
|
||
Status: NEW → RESOLVED
Closed: 16 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•