496879 - oncommand attribute on scrollbox is fired twice

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

When the oncommand attribute is used on a <scrollbox oncommand="alert('hey')"/>, the command if fired twice.
(It we inhibit one of the onmousedown/onmouseup event in ChromeInputModule#789, oncommand is fired once)

Comment 1

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Remove a allowNextClick

This seems to be related to bug 490873. 
In our case the click if fired twice, one time in sendSingleClick in ChromeInputHandler and another click is fired just after cause of the initial mousedown/mouseup. 
The reason why there is two 2 events is cause we call allowNextClick in sendSingleClick, and just after we call stopListening - so the click is fired from our calls to sendMouseEvent but allowNextClick stays to true for the next event.

This patch just remove allowNextClick() call in sendSingleClick

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Ben - We added the call for a different bug. What affect will this have on the original issue?

Comment 3

[Ben Combee (:bcombee)]

The click changes were added to handle the problem of a click being sent in chrome at the end of a drag.  sendSingleClick is just used from content, so I think it will be OK.  I'm in the process of testing the patch to see if I can find any bad behavior.

Comment 4

[Ben Combee (:bcombee)]

Comment on attachment 382296 [details] [diff] [review]
Remove a allowNextClick

The change is sound.  That code is the only place using stopListener/startListener, so this looks complete to me.  I didn't notice any bad effects while testing.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Looked good to me too:
http://hg.mozilla.org/mobile-browser/rev/56ebaffd1990

Comment 6

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

This bug also affect the current prefs panel, as two clicks are dispatched to the radio button when we try to change a pref and result to switch the value on the first click (as we want) and switch it back on the second click.

Comment 7

[Dão Gottwald [:dao]]

bugspam