Enabling NJ_ARM_VFP in NativeARM.h enabled vector floating point support back end generation. When running in this mode, the jit hits asserts.
Assignee: nobody → rreitmai
Priority: -- → P1
Target Milestone: --- → flash10.x
Noted that getresv() can return NULL in Assembler::freeRsrcOf() in Assembler.cpp when NJ_ARM_VFP is enabled. This causes a NULL pointer crash.
BTW, when fixing this please try to expose that setting through core/avmfeatures.as; it's the kind of thing we want to be very visible.
Tom: quick fix for this crash is to move freeRsrcOf() call into the non-vfp ifdef. The prepResultReg() in the vfp portion of code, releases the resource. I'll post a patch with this and other fixes as I run through the rest of the test suite.
Created attachment 384782 [details] [diff] [review] ver 1 bug introduced in VFP when bug 477228 was fixed. prepResultReg() in the VFP case clears the resources on the instruction, so freeRsrc() that was added should have been only added to non-VFP code.
Attachment #384782 - Flags: superreview?
Attachment #384782 - Flags: superreview? → review?(edwsmith)
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Resolved fixed engineering / work item that has been pushed. Setting status to verified.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.