496988 - ARM JIT fails when VFP is enabled.

Status: VERIFIED FIXED

(Tamarin Graveyard :: Baseline JIT (CodegenLIR), defect, P1)

Description

[Rick Reitmaier]

Enabling NJ_ARM_VFP in NativeARM.h enabled vector floating point support back end generation.  When running in this mode, the jit hits asserts.

Comment 1

[Tom Donovan]

Noted that getresv() can return NULL in Assembler::freeRsrcOf() in Assembler.cpp  when NJ_ARM_VFP is enabled. This causes a NULL pointer crash.

Comment 2

[Lars T Hansen]

BTW, when fixing this please try to expose that setting through core/avmfeatures.as; it's the kind of thing we want to be very visible.

Comment 3

[Rick Reitmaier]

Tom: quick fix for this crash is to move freeRsrcOf() call into the non-vfp ifdef.  The prepResultReg() in the vfp portion of code, releases the resource.

I'll post a patch with this and other fixes as I run through the rest of the test suite.

Comment 4

[Rick Reitmaier]

Attachment: ver 1

bug introduced in VFP when bug 477228 was fixed.  

prepResultReg() in the VFP case clears the resources on the instruction, so freeRsrc() that was added should have been only added to non-VFP code.

Comment 5

[Rick Reitmaier]

pushed http://hg.mozilla.org/tamarin-redux/rev/588ad07ccf31

Comment 6

[Chris Peyer]

Resolved fixed engineering / work item that has been pushed.  Setting status to verified.