496989 - Simplify text/glyph interface

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Robert Longson [:longsonr]]

Attachment: patch

Second step towards bug 388547 (bug 406312 was the first).

Makes dominant baseline work on each fragment.

Comment 1

[Jonathan Watt [:jwatt]]

Comment on attachment 382203 [details] [diff] [review]
patch

r=jwatt

>+nsSVGGlyphFrame::GetSubStringAdvance(PRUint32 charnum, 
>+                                     PRUint32 fragmentChars)
>+{
>+  if (fragmentChars == 0)
>+    return 0.0f;
>+
>+  gfxFloat advance = mTextRun->GetAdvanceWidth(charnum, fragmentChars, nsnull);
>+  return float(advance);

Not sure why you need the variable 'advance' here.

Comment 2

[Robert Longson [:longsonr]]

Lots of new code is going to go in between the gfxFloat advance and the return in the next patch in this exciting series.

Comment 3

[Robert Longson [:longsonr]]

checked in http://hg.mozilla.org/mozilla-central/rev/6bea55351cd1